Skip to content

Avoid setpgid for inherited stdio on macOS #8691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seeekr wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −1
Open

Avoid setpgid for inherited stdio on macOS #8691

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1585b67
Avoid setpgid for inherited stdio
seeekr Jan 2, 2026
576977d
Merge branch 'main' into fix/macos-sandbox-stdio-setpgid
etraut-openai Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion codex-rs/core/src/spawn.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,11 @@ pub(crate) async fn spawn_child_async(

#[cfg(unix)]
unsafe {
let set_process_group = matches!(stdio_policy, StdioPolicy::RedirectForShellTool);
#[cfg(target_os = "linux")]
let parent_pid = libc::getpid();
cmd.pre_exec(move || {
if libc::setpgid(0, 0) == -1 {
if set_process_group && libc::setpgid(0, 0) == -1 {
return Err(std::io::Error::last_os_error());
}

Expand Down
Loading