Skip to content

Conversation

@heathdutton
Copy link

Fixes #8240

When users define a model provider in config.toml with the same name as a built-in provider (e.g., ollama), the user's configuration should override the built-in defaults. Previously, or_insert was used which only inserted if the key didn't exist, causing user-defined base_url values to be ignored for built-in provider names.

Changed to insert so user-defined providers properly override built-in ones.

Added a regression test to verify the fix.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@heathdutton
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ollama support assumes localhost, ignoring config.toml

1 participant