fix(config): allow user-defined providers to override built-in providers #8670
+47
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8240
When users define a model provider in
config.tomlwith the same name as a built-in provider (e.g.,ollama), the user's configuration should override the built-in defaults. Previously,or_insertwas used which only inserted if the key didn't exist, causing user-definedbase_urlvalues to be ignored for built-in provider names.Changed to
insertso user-defined providers properly override built-in ones.Added a regression test to verify the fix.