Conversation
gt-oai
approved these changes
Dec 18, 2025
Collaborator
|
@codex review |
jif-oai
approved these changes
Dec 18, 2025
Contributor
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over in
config_loader/macos.rs, we were doing this complicatedmodthing to expose one version ofload_managed_admin_config_layer()for Mac:codex/codex-rs/core/src/config_loader/macos.rs
Lines 4 to 5 in 580c59a
While exposing a trivial implementation for non-Mac:
codex/codex-rs/core/src/config_loader/macos.rs
Lines 110 to 117 in 580c59a
That was being used like this:
codex/codex-rs/core/src/config_loader/layer_io.rs
Lines 47 to 48 in 580c59a
This PR simplifies that callsite in
layer_io.rsto just be:And updates
config_loader/mod.rsso we only pull inmacos.rson Mac:This simplifies
macos.rsconsiderably, though it looks like a big change because everything gets unindented and reformatted because we can drop the wholemod nativething now.Stack created with Sapling. Best reviewed with ReviewStack.