Conversation
|
@codex review this |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review this |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
| #[instrument(skip_all, fields(call = ?call))] | ||
| pub(crate) fn handle_tool_call( | ||
| &self, | ||
| self, |
There was a problem hiding this comment.
so we don't have to the tool runtime in a short lived function
| }) | ||
| .await?; | ||
|
|
||
| let _ = first_gate_tx.send(()); |
There was a problem hiding this comment.
these feel like useless gates, make the gate optional?
| .map_err(|err| anyhow::anyhow!("invalid timestamp {line:?}: {err}")) | ||
| }) | ||
| .collect::<Result<Vec<_>, _>>()?; | ||
| if timestamps.len() == 4 { |
There was a problem hiding this comment.
why do we need so many?
pakrym-oai
left a comment
pakrym-oai
left a comment
There was a problem hiding this comment.
You are accepted into high-quality unit-test society! This is awesome!
2 participants
No description provided.