-
Notifications
You must be signed in to change notification settings - Fork 5.3k
CLI/TUI: show resume file path; picker [project] tag; plain verify #4365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CLI/TUI: show resume file path; picker [project] tag; plain verify #4365
Conversation
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
codex/codex-rs/tui/src/resume_picker.rs
Lines 434 to 444 in 43c48d9
fn apply_filter(&mut self) { | |
if self.query.is_empty() { | |
self.filtered_rows = self.all_rows.clone(); | |
} else { | |
let q = self.query.to_lowercase(); | |
self.filtered_rows = self | |
.all_rows | |
.iter() | |
.filter(|r| r.preview.to_lowercase().contains(&q)) | |
.cloned() | |
.collect(); |
[P1] Query filtering ignores project tag and path
The new /resume <query>
flow depends on being able to filter by the [project]
tag or rollout path, but the filtering logic still only checks Row.preview
. apply_filter
lowercases the query and returns rows where r.preview
contains the substring, never examining r.project
or r.path
. A command like /resume tmp
(or the CODEX_TUI_FILTER
env var) will therefore not match sessions whose project tag is [tmp]
unless the preview text also contains tmp
. This makes the advertised project/path filtering ineffective.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
0833f5d
to
e305be7
Compare
I have read the CLA Document and I hereby sign the CLA |
I have read the CLA Document and I hereby sign the CLA |
…y + filter; panic hook for alt-screen cleanup; tests green Signed-off-by: Graham Anderson <graham@grahama.co>
e305be7
to
4b863cc
Compare
Title
CLI/TUI: show resume file path; picker [project] tag; plain verify
Summary
Problems
Fixes
resume file:
with the absolute rollout path in the initial config summary on resume.[project]
tag (derived fromSessionMeta.cwd
basename) after the time.resume file:
line directly under the header when resuming.Scope
Risk
User‑Visible Changes
CLI
resume file: /absolute/path/to/sessions/YYYY/MM/DD/rollout-...jsonl
TUI
> 1 minute ago [project] preview…
[project]
=basename(SessionMeta.cwd)
; styled cyan + bold.resume file:
line directly under the header on resume.Implementation Notes
CLI
codex-rs/exec/src/event_processor_with_human_output.rs
print_config_summary
(resume only):TUI — Resume picker
[project]
tagcodex-rs/tui/src/resume_picker.rs
project
fromSessionMeta.cwd
basename inhead_to_row
(UTF‑8 safe).format!("[{}]", tag).cyan().bold()
.TUI — Resumed header
resume file:
linecodex-rs/tui/src/history_cell.rs
"resume file:"
(dim) +rollout_path.display()
.Dev‑only verification helpers
codex-rs/tui/src/resume_picker.rs
CODEX_TUI_PLAIN=1
, print picker rows and exit (honorsNO_COLOR
/TERM=dumb
).CODEX_TUI_FILTER
is set, pre‑filter rows by substring match over[project]
, preview, or path.Change Surface
codex-rs/exec/src/event_processor_with_human_output.rs
codex-rs/tui/src/resume_picker.rs
codex-rs/tui/src/history_cell.rs
codex-rs/tui/src/lib.rs
(panic hook to leave alt‑screen on panic)Compatibility
SessionConfiguredEvent.rollout_path
.Testing Plan
Automated
Manual (network‑free via SSE fixture)
Accessibility & Styling
[project]
tag uses cyan + bold in TUI (consistent with existing status styling).NO_COLOR
andTERM=dumb
).Performance, Security, Privacy
Risks & Mitigations
cwd
: guarded.Rollout / Backout
Developer Notes
cd codex-rs && just fmt
cd codex-rs && just fix -p codex-exec && just fix -p codex-tui
local/
out of repo history (use.git/info/exclude
).