ref: state - 2 #4229
Merged
ref: state - 2 #4229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codex review this deeply |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting |
|
There is a known bug with the sync abort. Fix in progress |
pakrym-oai
reviewed
Sep 25, 2025
pakrym-oai
reviewed
Sep 25, 2025
pakrym-oai
reviewed
Sep 25, 2025
pakrym-oai
reviewed
Sep 25, 2025
pakrym-oai
reviewed
Sep 25, 2025
pakrym-oai
reviewed
Sep 25, 2025
pakrym-oai
reviewed
Sep 25, 2025
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn abort_regular_task_emits_turn_aborted_only() { |
There was a problem hiding this comment.
have you considered making these integration style tests? We can simulate never ending task by having server return tool calls forever.
also maybe movign them out of codex.rs
There was a problem hiding this comment.
Yes I want to add full integration tests around this but still in todo
pakrym-oai
approved these changes
Sep 25, 2025
|
@codex fix the CLI |
|
Summary
Testing
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting tasks in a module and start abstraction behind a Trait (more to come on this but each task will be tackled in a dedicated PR)
The goal was to drop the ActiveTask and to have a (potentially) set of tasks during each turn