Skip to content

Build filesystem JSON params only for remote TUI sessions #39077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copyberry merged 1 commit into from
Aug 17, 2026
Merged

Build filesystem JSON params only for remote TUI sessions #39077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions codex-rs/tui/src/app_server_session/fs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ impl AppServerSession {
recursive: Some(true),
},
},
json!({ "path": path.as_str(), "recursive": true }),
|| json!({ "path": path.as_str(), "recursive": true }),
)
.await
.map(drop)
Expand All @@ -57,7 +57,7 @@ impl AppServerSession {
data_base64: data_base64.clone(),
},
},
json!({ "path": path.as_str(), "dataBase64": data_base64 }),
|| json!({ "path": path.as_str(), "dataBase64": data_base64 }),
)
.await
.map(drop)
Expand All @@ -72,7 +72,7 @@ impl AppServerSession {
request_id,
params: FsReadFileParams { path },
},
json!({ "path": path.as_str() }),
|| json!({ "path": path.as_str() }),
)
.await?;
STANDARD
Expand All @@ -92,7 +92,7 @@ impl AppServerSession {
force: None,
},
},
json!({ "path": path.as_str() }),
|| json!({ "path": path.as_str() }),
)
.await
.map(drop)
Expand All @@ -103,7 +103,7 @@ impl AppServerSession {
method: &str,
path: &AppServerPath,
local_request: impl FnOnce(RequestId, AbsolutePathBuf) -> ClientRequest,
remote_params: serde_json::Value,
remote_params: impl FnOnce() -> serde_json::Value,
) -> Result<T> {
let request_id = self.next_request_id();
match self.request_handle() {
Expand All @@ -112,7 +112,7 @@ impl AppServerSession {
.request_json_rpc(JSONRPCRequest {
id: request_id,
method: method.to_string(),
params: Some(remote_params),
params: Some(remote_params()),
trace: None,
})
.await
Expand Down
Loading