chore: upgrade to Rust 1.89 #2465
Merged
+496
−513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolinfest
force-pushed
the
pr2465
branch
2 times, most recently
from
5ac2cbe to
c6f4144
Compare
bolinfest
force-pushed
the
pr2465
branch
2 times, most recently
from
3cc22c0 to
76d33fc
Compare
dylan-hurd-oai
approved these changes
Aug 19, 2025
| out.extend_from_slice(&commands[idx + 1..]); | ||
| return Some(out); | ||
| } | ||
| }) && commands |
There was a problem hiding this comment.
I'm in favor of standardization but some of these feel a bit complicated
There was a problem hiding this comment.
Understood, though it is a losing battle against Clippy (unless we choose to disable this rule?). I think, in general, avoiding the nested ifs is for the best.
| @@ -309,7 +309,7 @@ where | |||
| } | |||
|
|
|||
| /// Get a Frame object which provides a consistent view into the terminal state for rendering. | |||
| pub fn get_frame(&mut self) -> Frame { | |||
| pub fn get_frame(&mut self) -> Frame<'_> { | |||
There was a problem hiding this comment.
unrelated lifetime change? Or is this newly required to be explicit?
There was a problem hiding this comment.
Good eye!
Yes, it appears this has changed:
https://blog.rust-lang.org/2025/08/07/Rust-1.89.0/#mismatched-lifetime-syntaxes-lint
bolinfest
added a commit
that referenced
this pull request
Aug 19, 2025
) The `ubuntu-24.04 - x86_64-unknown-linux-gnu` build is failing with `No space left on device` on #2465, so let's get this in first, which should help. Note that `cargo check` should be faster and use less disk than `cargo build` because it does not write out the object files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codex created this PR from the following prompt:
Note this modifies a lot of lines because it folds nested
ifstatements using&&.Stack created with Sapling. Best reviewed with ReviewStack.