-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Support changing reasoning effort #2435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2bf898d
start
aibrahim-oai 88b6af8
update
aibrahim-oai d4dd306
UX
aibrahim-oai bc6778d
UX
aibrahim-oai 9e4ec31
final
aibrahim-oai 0e89f06
Merge branch 'main' into reasoning-effort-tui
aibrahim-oai 525a2ea
new file
aibrahim-oai a386a40
trace remove
aibrahim-oai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
use codex_core::protocol_config_types::ReasoningEffort; | ||
|
||
/// A simple preset pairing a model slug with a reasoning effort. | ||
#[derive(Debug, Clone, Copy)] | ||
pub struct ModelPreset { | ||
/// Stable identifier for the preset. | ||
pub id: &'static str, | ||
/// Display label shown in UIs. | ||
pub label: &'static str, | ||
/// Short human description shown next to the label in UIs. | ||
pub description: &'static str, | ||
/// Model slug (e.g., "gpt-5"). | ||
pub model: &'static str, | ||
/// Reasoning effort to apply for this preset. | ||
pub effort: ReasoningEffort, | ||
} | ||
|
||
/// Built-in list of model presets that pair a model with a reasoning effort. | ||
/// | ||
/// Keep this UI-agnostic so it can be reused by both TUI and MCP server. | ||
pub fn builtin_model_presets() -> &'static [ModelPreset] { | ||
// Order reflects effort from minimal to high. | ||
const PRESETS: &[ModelPreset] = &[ | ||
ModelPreset { | ||
id: "gpt-5-minimal", | ||
label: "gpt-5 minimal", | ||
description: "— Fastest responses with very limited reasoning; ideal for coding, instructions, or lightweight tasks.", | ||
model: "gpt-5", | ||
effort: ReasoningEffort::Minimal, | ||
}, | ||
ModelPreset { | ||
id: "gpt-5-low", | ||
label: "gpt-5 low", | ||
description: "— Balances speed with some reasoning; useful for straightforward queries and short explanations.", | ||
model: "gpt-5", | ||
effort: ReasoningEffort::Low, | ||
}, | ||
ModelPreset { | ||
id: "gpt-5-medium", | ||
label: "gpt-5 medium", | ||
description: "— Default setting; provides a solid balance of reasoning depth and latency for general-purpose tasks.", | ||
model: "gpt-5", | ||
effort: ReasoningEffort::Medium, | ||
}, | ||
ModelPreset { | ||
id: "gpt-5-high", | ||
label: "gpt-5 high", | ||
description: "— Maximizes reasoning depth for complex or ambiguous problems.", | ||
model: "gpt-5", | ||
effort: ReasoningEffort::High, | ||
}, | ||
]; | ||
PRESETS | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update config.md to reflect this change.