fix(core) request_permissions tool flakey test - #20744
Closed
dylan-hurd-oai wants to merge 1 commit into
Closed
Conversation
won-openai
approved these changes
May 2, 2026
This was referenced May 3, 2026
Contributor
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a flaky macOS codex-core test:
approved_folder_write_request_permissions_unblocks_later_apply_patch
The test had two sources of nondeterminism:
machines configured with auto_review, the request_permissions tool call could be routed through
Guardian instead of emitting the RequestPermissions event the test expected.
permissions request. In practice, unrelated completion events can be observed before the specific
permissions event, causing the test to fail even though the expected request may still arrive.
This change makes the test deterministic by defaulting test turns to ApprovalsReviewer::User unless a
subcase explicitly overrides it, and by waiting for the specific RequestPermissions call id. The strict
auto-review subcase also now provides two mocked Guardian allow responses, matching the two review
requests made on that path.
Testing
Ran the test 5 times:
cargo test -p codex-core --test all approved_folder_write_request_permissions_unblocks_later_apply_patch -- --nocapture