Skip to content

feat: memories forgetting#12900

Merged
jif-oai merged 8 commits intomainfrom
jif/memories-forgetting
Feb 26, 2026
Merged

feat: memories forgetting#12900
jif-oai merged 8 commits intomainfrom
jif/memories-forgetting

Conversation

@jif-oai
Copy link
Collaborator

@jif-oai jif-oai commented Feb 26, 2026

Add diff based memory forgetting

@jif-oai
Copy link
Collaborator Author

jif-oai commented Feb 26, 2026

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4a3c3ca176

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai
Copy link
Collaborator Author

jif-oai commented Feb 26, 2026

@codex reviww

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4ed8f10495

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai
Copy link
Collaborator Author

jif-oai commented Feb 26, 2026

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

ON CONFLICT(thread_id) DO UPDATE SET
source_updated_at = excluded.source_updated_at,
raw_memory = excluded.raw_memory,
rollout_summary = excluded.rollout_summary,
rollout_slug = excluded.rollout_slug,
generated_at = excluded.generated_at

P1 Badge Treat regenerated selected threads as newly added input

The ON CONFLICT upsert rewrites source_updated_at/raw_memory/rollout_slug but leaves selected_for_phase2 unchanged. A thread selected in the previous run stays flagged even after new stage-1 content arrives, so diffing can classify fresh evidence as retained instead of added. With the new prompt flow, that can skip reprocessing updated memory and leave stale guidance.


if let Err(err) =
sync_rollout_summaries_from_memories(&root, &raw_memories, max_raw_memories).await

P2 Badge Keep removed rollout summaries available during consolidation

Phase-2 prunes rollout_summaries before spawning the consolidation agent. The new incremental prompt asks the agent to use removed threads' summary files when thread_id tags are missing or mixed blocks need provenance checks. Deleting those files first removes required evidence and can prevent correct stale-memory cleanup.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai
Copy link
Collaborator Author

jif-oai commented Feb 26, 2026

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d03cafdca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai jif-oai merged commit 382fa33 into main Feb 26, 2026
32 checks passed
@jif-oai jif-oai deleted the jif/memories-forgetting branch February 26, 2026 13:20
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant