Conversation
|
@codex review |
# Conflicts: # codex-rs/state/src/model/memories.rs
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a3c3ca176
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex reviww |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ed8f10495
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
codex/codex-rs/state/src/runtime/memories.rs
Lines 605 to 610 in ad71ac3
The ON CONFLICT upsert rewrites source_updated_at/raw_memory/rollout_slug but leaves selected_for_phase2 unchanged. A thread selected in the previous run stays flagged even after new stage-1 content arrives, so diffing can classify fresh evidence as retained instead of added. With the new prompt flow, that can skip reprocessing updated memory and leave stale guidance.
codex/codex-rs/core/src/memories/phase2.rs
Lines 90 to 91 in ad71ac3
Phase-2 prunes rollout_summaries before spawning the consolidation agent. The new incremental prompt asks the agent to use removed threads' summary files when thread_id tags are missing or mixed blocks need provenance checks. Deleting those files first removes required evidence and can prevent correct stale-memory cleanup.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d03cafdca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add diff based memory forgetting