fix(execpolicy) Handle heredoc parsing #10339
Open
+219
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylan-hurd-oai
force-pushed
the
dh--exec-policy-parsing-1
branch
from
f0ab62a to
1ba6837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pythonprefix approval isn't working because parsing was failing on heredoc usage. This updates execpolicy parsing to handle this case, while still guarding against substitution in the commandOpen Question for discussion: do we want to fold this into
parse_shell_lc_plain_commands? I'm less certain so I left it separate for now.Testing