app-server: add fuzzy search sessions for streaming file search #10268
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee9bed72d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let query = { | ||
| #[expect(clippy::unwrap_used)] | ||
| self.shared.latest_query.lock().unwrap().clone() | ||
| }; | ||
| if query.is_empty() || snapshot.query != query { | ||
| return; |
There was a problem hiding this comment.
When a client clears the search input it will typically call sessionUpdate with an empty query. This code sets latest_query to the empty string but then suppresses all snapshots via if query.is_empty() ... return;, so the client receives an OK response but never gets a fuzzyFileSearch/sessionUpdated notification to clear prior results. That leaves stale matches visible until another non-empty query arrives. Consider allowing empty queries to emit a snapshot (likely with empty matches) so the UI can clear immediately.
Useful? React with 👍 / 👎.
No description provided.