chore: rename ChatGpt -> Chatgpt in type names #10244
Merged
+55
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolinfest
changed the title
bolinfest
force-pushed
the
pr10244
branch
2 times, most recently
from
c04df09 to
96a2bc8
Compare
owenlin0
approved these changes
Jan 30, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ChatGPT in names of types, we should be consistent, so this renames some types with
ChatGptin the name toChatgpt. From https://rust-lang.github.io/api-guidelines/naming.html:This PR updates existing uses of
ChatGptand changes them toChatgpt. Though in all cases where it could affect the wire format, I visually inspected that we don't change anything there. That said, this will change the codegen because it will affect the spelling of type names.For example, this renames
AuthMode::ChatGPTtoAuthMode::Chatgptinapp-server-protocol, but the wire format is still"chatgpt".This PR also updates a number of types in
codex-rs/core/src/auth.rs.