add error messages for the go plan type #10181
Conversation
willwang-openai
force-pushed
the
willwang/add-go-plan-type
branch
from
17bf311 to
5c39279
Compare
willwang-openai
force-pushed
the
willwang/add-go-plan-type
branch
from
5c39279 to
ffb98ca
Compare
willwang-openai
force-pushed
the
willwang/add-go-plan-type
branch
from
cb93827 to
8855aac
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb938279a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assert_eq!( | ||
| err.to_string(), | ||
| "You've hit your usage limit. Upgrade to Plus to continue using Codex (https://openai.com/chatgpt/pricing)." | ||
| "You've hit your usage limit. Upgrade to Plus to continue using Codex (https://openai.com/chatgpt/pricing), or try again later." | ||
| ); |
There was a problem hiding this comment.
The expected string in usage_limit_reached_error_formats_free_plan (and the new Go-plan test right after it) still asserts https://openai.com/chatgpt/pricing, but UsageLimitReachedError::fmt now emits https://chatgpt.com/codex/settings/usage for Free/Go plans. As written, these unit tests will fail whenever the core error tests are run, masking the intended message update.
Useful? React with 👍 / 👎.
willwang-openai
force-pushed
the
willwang/add-go-plan-type
branch
from
8855aac to
3c336f5
Compare
Adds support for the Go plan type
Updates rate limit error messages to point to the usage page