chore(personality) new schema with fallbacks #10147
Merged
+607
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym-oai
reviewed
Jan 29, 2026
pakrym-oai
reviewed
Jan 29, 2026
pakrym-oai
reviewed
Jan 29, 2026
pakrym-oai
reviewed
Jan 29, 2026
dylan-hurd-oai
force-pushed
the
dh--tune-personality-params
branch
from
8ba8c91 to
c42d2d3
Compare
aibrahim-oai
approved these changes
Jan 30, 2026
aibrahim-oai
approved these changes
Jan 30, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Let's dial in this api contract in a bit more with more robust fallback behavior when model_instructions_template is false.
Switches to a more explicit template / variables structure, with more fallbacks.
Testing