Refine request_user_input TUI interactions and option UX #10025

charley-oai · 2026-01-27T20:20:48Z

Summary

Overhaul the ask‑user‑questions TUI to support “Other/None” answers, better notes handling, improved option selection
UX, and a safer submission flow with confirmation for unanswered questions.

Resolves #10088

Multiple choice (number keys for quick selection, up/down or jk for cycling through options):

Tab to add notes:

Freeform (also note enter tooltip is highlighted on last question to indicate questions UI will be exited upon submission):

Confirmation dialogue (submitting with unanswered questions):

Key Changes

Options UI refresh
- Render options as numbered entries; allow number keys to select & submit.
- Remove “Option X/Y” header and allow the question UI height to expand naturally.
- Keep spacing between question, options, and notes even when notes are visible.
- Hide the title line and render the question prompt in cyan only when uncommitted.
“Other / None of the above” support
- Wire isOther to add “None of the above”.
- Add guidance text: “Optionally, add details in notes (tab).”
Notes composer UX
- Remove “Notes” heading; place composer directly under the selected option.
- Preserve pending paste placeholders across question navigation and after submission.
- Ctrl+C clears notes only when the notes composer has focus.
- Ctrl+C now triggers an immediate redraw so the clear is visible.
Committed vs uncommitted state
- Introduce a unified answer_committed flag per question.
- Editing notes (including adding text or pastes) marks the answer uncommitted.
- Changing the option highlight (j/k, up/down) marks the answer uncommitted.
- Clearing options (Backspace/Delete) also clears pending notes.
- Question prompt turns cyan only when the answer is uncommitted.
Submission safety & confirmation
- Only submit notes/freeform text once explicitly committed.
- Last-question submit with unanswered questions shows a confirmation dialog.
- Confirmation options:
  1. Proceed (default)
  2. Go back
- Description reflects count: “Submit with N unanswered question(s).”
- Esc/Backspace in confirmation returns to first unanswered question.
- Ctrl+C in confirmation interrupts and exits the overlay.
Footer hints
- Cyan highlight restored for “enter to submit answer” / “enter to submit all”.

Codex author

codex fork 019c00ed-323a-7000-bdb5-9f9c5a635bd9

charley-oai · 2026-01-27T20:21:14Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7efe081a2f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs

charley-oai · 2026-01-27T20:36:48Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 901d918476

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs

charley-oai · 2026-01-27T22:03:26Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bd473d1021

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs

charley-oai · 2026-01-27T22:44:50Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 467bba1c6f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs

charley-oai · 2026-01-27T23:19:38Z

@codex review this

chatgpt-codex-connector · 2026-01-27T23:27:00Z

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai · 2026-01-28T00:40:23Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/tui/src/bottom_pane/request_user_input/layout.rs

Lines 284 to 286 in 61acfa6

    
           ) -> (u16, u16, u16, u16, u16, u16, u16, u16) { 
        
               let max_question_height = available_height.saturating_sub(1); 
        
               let adjusted_question_height = question_height.min(max_question_height);

Fix off-by-one truncation in tight freeform layout

In the tight no-options path you still reserve an extra row (available_height.saturating_sub(1)) even though this commit removed the header line entirely (header height is now 0). When the pane is constrained (e.g., question wraps to 2 lines and only 2 rows are available), this forces max_question_height to 1 and truncates a line that would fit, leaving a blank row. Consider using the full available_height here or only subtracting when a header/progress row is actually rendered.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai · 2026-01-28T04:39:41Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2a1a02d3b2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs

charley-oai · 2026-01-28T05:07:52Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 16c571e8bf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs

charley-oai · 2026-01-28T06:12:06Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cbfe0c12ee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs

charley-oai · 2026-01-28T07:04:47Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/tui/src/bottom_pane/request_user_input/mod.rs

Lines 676 to 680 in 47c9ec2

    
           let options = question.options.as_ref(); 
        
           // For option questions we may still produce no selection. 
        
           let selected_idx = if options.is_some_and(|opts| !opts.is_empty()) { 
        
               answer_state.committed_option_idx 
        
           } else {

Skip submitting stale options when answer is uncommitted

Right now submit_answers always uses committed_option_idx for option questions, even when answer_committed is false. This can happen after a user changes the highlighted option or edits notes (which marks the answer uncommitted). In that case the UI treats the question as “unanswered” (see is_question_answered), but proceeding still submits the previously committed option without the user re‑confirming it, which is inconsistent with the confirmation dialog and can silently send a stale choice. Consider gating option submission on answer_committed (or clearing committed_option_idx when you mark it uncommitted).

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai · 2026-01-28T08:49:32Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b174e95b83

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs

charley-oai · 2026-01-28T09:28:57Z

@codex review this

chatgpt-codex-connector · 2026-01-28T09:47:44Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector bot reviewed Jan 27, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs Show resolved Hide resolved

charley-oai force-pushed the ask-user-question-is-other-in-tui branch from 7efe081 to 901d918 Compare January 27, 2026 20:36

chatgpt-codex-connector bot reviewed Jan 27, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs Outdated Show resolved Hide resolved

charley-oai force-pushed the ask-user-question-is-other-in-tui branch from 901d918 to bd473d1 Compare January 27, 2026 22:03

charley-oai force-pushed the ask-user-question-is-other-in-tui branch from bd473d1 to 7afa1f3 Compare January 27, 2026 22:07

chatgpt-codex-connector bot reviewed Jan 27, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs Show resolved Hide resolved

charley-oai changed the base branch from main to ask-user-question-ui-footer-improvements January 27, 2026 22:43

charley-oai force-pushed the ask-user-question-is-other-in-tui branch from 7afa1f3 to 467bba1 Compare January 27, 2026 22:44

chatgpt-codex-connector bot reviewed Jan 27, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs Outdated Show resolved Hide resolved

charley-oai changed the base branch from ask-user-question-ui-footer-improvements to main January 27, 2026 22:56

Request user input: support is_other + reset freeform commits

2931294

charley-oai force-pushed the ask-user-question-is-other-in-tui branch from fa11349 to 2931294 Compare January 27, 2026 23:17

charley-oai added 2 commits January 27, 2026 15:22

Delete scroll tooltip because it's obvious

4b3feec

Lint

3af6e62

Refine request user input options UI

61acfa6

charley-oai changed the title ~~TUI: honor isOther in request_user_input with “None of the above”~~ Refine request_user_input TUI interactions and option UX Jan 28, 2026

chatgpt-codex-connector bot reviewed Jan 28, 2026

View reviewed changes

charley-oai added 3 commits January 27, 2026 17:26

Adjust ask-user-question overlay UI

8db628d

Tighten notes spacing in ask-user-question UI

4b440a4

Improve request user input commit flow

2a1a02d

chatgpt-codex-connector bot reviewed Jan 28, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs Show resolved Hide resolved

Fix option shortcut committing

3e1361c

chatgpt-codex-connector bot reviewed Jan 28, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs Outdated Show resolved Hide resolved

Commit option when submitting empty notes

cbfe0c1

chatgpt-codex-connector bot reviewed Jan 28, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs Show resolved Hide resolved

Keep notes and footer for long option lists

47c9ec2

Add unanswered confirmation snapshot

f680d05

chatgpt-codex-connector bot reviewed Jan 28, 2026

View reviewed changes

charley-oai added 6 commits January 27, 2026 23:48

Document spacer rows in request user input

552d758

Show option index in footer when scrolling

0876819

Expand pending pastes via text elements

5e2d969

Remove committed option state

486844c

Refine ctrl+n footer hints

0bd3b2c

Add page up/down question navigation

b174e95

Extract notes spacer constant

b177907

chatgpt-codex-connector bot reviewed Jan 28, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs Show resolved Hide resolved

charley-oai added 3 commits January 28, 2026 01:07

Explain spacer choice with notes

bc7598c

Require paste placeholders to have elements

2e39905

Commit selection on space

3a4169b

Rename confirmation helpers

ea5769f

charley-oai marked this pull request as ready for review January 28, 2026 09:52

Deduplicate confirmation layout

2eeaf22

pakrym-oai approved these changes Jan 28, 2026

View reviewed changes

charley-oai merged commit 9638675 into main Jan 28, 2026
51 of 53 checks passed

charley-oai deleted the ask-user-question-is-other-in-tui branch January 28, 2026 17:42

github-actions bot locked and limited conversation to collaborators Jan 28, 2026

	) -> (u16, u16, u16, u16, u16, u16, u16, u16) {
	let max_question_height = available_height.saturating_sub(1);
	let adjusted_question_height = question_height.min(max_question_height);

	let options = question.options.as_ref();
	// For option questions we may still produce no selection.
	let selected_idx = if options.is_some_and(\|opts\| !opts.is_empty()) {
	answer_state.committed_option_idx
	} else {

Refine request_user_input TUI interactions and option UX #10025

Refine request_user_input TUI interactions and option UX #10025

Conversation

charley-oai commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Key Changes

Codex author

Uh oh!

charley-oai commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot commented Jan 27, 2026

Uh oh!

charley-oai commented Jan 28, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

charley-oai commented Jan 28, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Jan 28, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Jan 28, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Jan 28, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

charley-oai commented Jan 28, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

charley-oai commented Jan 27, 2026 •

edited

Loading