Skip to content

Conversation

@jif-oai
Copy link
Collaborator

@jif-oai jif-oai commented Jan 27, 2026

Add a .sqlite database to be used to store rollout metatdata (and later logs)
This PR is phase 1:

  • Add the database and the required infrastructure
  • Add a backfill of the database
  • Persist the newly created rollout both in files and in the DB
  • When we need to get metadata or a rollout, consider the JSONL as the source of truth but compare the results with the DB and show any errors

@jif-oai
Copy link
Collaborator Author

jif-oai commented Jan 27, 2026

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b6aeb3ef1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai
Copy link
Collaborator Author

jif-oai commented Jan 28, 2026

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e4762c710a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai
Copy link
Collaborator Author

jif-oai commented Jan 28, 2026

@codex review

@jif-oai jif-oai merged commit 3878c3d into main Jan 28, 2026
32 checks passed
@jif-oai jif-oai deleted the jif/db-1 branch January 28, 2026 14:29
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2026
@bolinfest
Copy link
Collaborator

@jif-oai @aibrahim-oai There seems to be a lot of duplication across the two workflows. Can you please go and de-dupe this? .github/scripts/install-musl-build-tools.sh is an example of creating a script that can be shared across workflows.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants