Don't override atari-py when testing against gym #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesseFarebro
changed the title
pzhokhov
approved these changes
Jun 14, 2019
Merged
PaulMcMillan
pushed a commit
that referenced
this pull request
Apr 25, 2023
Don't override atari-py when testing against gym
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the discussion from #49.
If the current version of
atari-pydoesn't conform to the semver ofgym[atari]the package intended on being tested will be uninstalled. Removinggymas a test dependency might not be worth it if you intend to test against a ROM (as gym distributes the ROMs). Perhaps one solution to the problem is installinggymwithout theatarisuffix. In the CI tests you'll haveatari-pyinstalled before running the smoke test.