Fix undefined array key errors for xAI Responses API #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xAI Responses API does not return certain attributes. The `Responses/Responses/CreateResponse` class already allows these fields to be null. - Added null fallbacks to `instructions`, `outputText`, and `truncation` attributes
iBotPeaches
requested changes
Sep 24, 2025
Collaborator
iBotPeaches
left a comment
iBotPeaches
left a comment
There was a problem hiding this comment.
I understand the instructions and truncation one, but outputText is just an SDK property that pulls text from output and that has to be in xAI as its the entire point of response api.
Contributor
Author
|
Yeah I noticed that after I opened it last night, I'll fix it today to resolve the failing tests |
`$output` should always be defined, so no need to do null checks.
iBotPeaches
approved these changes
Sep 24, 2025
Collaborator
|
thanks for quick fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
xAI Responses API does not return certain attributes. The
Responses/Responses/CreateResponseclass already allows these fields to be null.instructions, andtruncationattributes to avoid errors when handling xAI Responses API response (e.g. grok-4)See xAI Docs