feat(OpenAI) - Add support for Image Generation Tool (Responses) #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Add support for the image_generation tool in response parsing, serialization, and fixtures
- Introduces
ImageGenerationToolandImageGenerationInputImageMaskclasses with parsing andtoArray()implementations - Updates
CreateResponseandRetrieveResponseto recognize the new tool type - Adds fixtures and tests for
toolImageGeneration()and adjusts existing test expectations
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Responses/Responses/Tool/ImageGenerationTool.php | Add tests for parsing/serializing the image_generation tool |
| tests/Responses/Responses/RetrieveResponse.php | Update expected tool count to include the new image generation |
| tests/Fixtures/Responses.php | Add toolImageGeneration() fixture and include it in responses |
| src/Responses/Responses/Tool/ImageGenerationTool.php | Implement ImageGenerationTool::from() and toArray() |
| src/Responses/Responses/Tool/ImageGenerationInputImageMask.php | Implement ImageGenerationInputImageMask::from() and toArray() |
| src/Responses/Responses/RetrieveResponse.php | Register ImageGenerationTool in parsing and serialization |
| src/Responses/Responses/CreateResponse.php | Register ImageGenerationTool in parsing and serialization |
Comments suppressed due to low confidence (1)
tests/Responses/Responses/CreateResponse.php:32
- The CreateResponse test still expects only 2 tools; update this to
->toHaveCount(3)so it covers the newly added image_generation tool.
->tools->toHaveCount(2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
Types responses from Responses API that contain
image_generationtool usage.Related:
fixes: #585