Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goodwe v1 1 #1727

Merged
merged 10 commits into from
Jul 5, 2024
Merged

Goodwe v1 1 #1727

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
09675ec
add version and firmware information
ndrsnhs Jun 28, 2024
fdde028
add alternative registers for battery and counter
ndrsnhs Jun 28, 2024
7bb9c12
fix breaking changes
ndrsnhs Jun 28, 2024
4e96645
Merge branch 'goodwe-v1_1' of https://github.com/ndrsnhs/core into go…
ndrsnhs Jun 28, 2024
0f8e906
solve breaking changes
ndrsnhs Jun 28, 2024
2f8f250
Merge branch 'openWB:master' into goodwe-v1_1
ndrsnhs Jul 1, 2024
aa4e79e
fix breaking changes, add comments
ndrsnhs Jul 1, 2024
9942c0d
fix SimCounter
ndrsnhs Jul 4, 2024
eec4f50
Merge branch 'goodwe-v1_1' of https://github.com/ndrsnhs/core into go…
ndrsnhs Jul 4, 2024
a304e66
remove duplicate lines
ndrsnhs Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/modules/devices/good_we/counter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from modules.common.component_type import ComponentDescriptor
from modules.common.fault_state import ComponentInfo, FaultState
from modules.common.modbus import ModbusDataType
from modules.common.simcount import SimCounter
from modules.common.store import get_counter_value_store
from modules.devices.good_we.config import GoodWeCounterSetup
from modules.devices.good_we.version import GoodWeVersion
Expand All @@ -22,6 +23,7 @@ def __init__(self,
self.__modbus_id = modbus_id
self.version = version
self.firmware = firmware
self.sim_counter = SimCounter(self.__device_id, self.component_config.id, prefix="bezug")
self.component_config = dataclass_from_dict(GoodWeCounterSetup, component_config)
self.__tcp_client = tcp_client
self.store = get_counter_value_store(self.component_config.id)
Expand Down