Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
LKuemmel committed Oct 15, 2024
1 parent 21ffe4e commit f847603
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion packages/modules/devices/growatt/growatt/bat.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from typing import Dict, Union

from dataclass_utils import dataclass_from_dict
from modules.common.abstract_device import AbstractBat
from modules.common.component_state import BatState
from modules.common.component_type import ComponentDescriptor
from modules.common.fault_state import ComponentInfo, FaultState
Expand All @@ -11,7 +12,7 @@
from modules.devices.growatt.growatt.version import GrowattVersion


class GrowattBat:
class GrowattBat(AbstractBat):
def __init__(self,
component_config: Union[Dict, GrowattBatSetup],
modbus_id: int,
Expand Down
3 changes: 2 additions & 1 deletion packages/modules/devices/growatt/growatt/counter.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from typing import Dict, Union

from dataclass_utils import dataclass_from_dict
from modules.common.abstract_device import AbstractCounter
from modules.common.component_state import CounterState
from modules.common.component_type import ComponentDescriptor
from modules.common.fault_state import ComponentInfo, FaultState
Expand All @@ -11,7 +12,7 @@
from modules.devices.growatt.growatt.version import GrowattVersion


class GrowattCounter:
class GrowattCounter(AbstractCounter):
def __init__(self,
component_config: Union[Dict, GrowattCounterSetup],
modbus_id: int,
Expand Down
3 changes: 2 additions & 1 deletion packages/modules/devices/growatt/growatt/inverter.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from typing import Dict, Union

from dataclass_utils import dataclass_from_dict
from modules.common.abstract_device import AbstractInverter
from modules.common.component_state import InverterState
from modules.common.component_type import ComponentDescriptor
from modules.common.fault_state import ComponentInfo, FaultState
Expand All @@ -11,7 +12,7 @@
from modules.devices.growatt.growatt.version import GrowattVersion


class GrowattInverter:
class GrowattInverter(AbstractInverter):
def __init__(self,
component_config: Union[Dict, GrowattInverterSetup],
modbus_id: int,
Expand Down

0 comments on commit f847603

Please sign in to comment.