Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chroot: add apply_, sls and highstate for state execution #187

Merged
merged 4 commits into from
May 12, 2020

Conversation

aplanas
Copy link
Contributor

@aplanas aplanas commented Nov 18, 2019

What does this PR do?

Based on the code from the SSH client wrapper, add apply_, sls and highstate for the execution of Salt states inside a chroot environment.

Tests written?

Yes

(backport of saltstack/salt#55345)

@meaksh meaksh force-pushed the openSUSE-2019.2.0 branch from 2a851c5 to b86c2b0 Compare December 4, 2019 16:11
(cherry picked from commit 05afc0b783940c53a6d555b8c5b8082e3fc4295d)
Some bug in Salt is preventing to use `archive.tar` inside chroot, we we
want to untar the salt_thin.tgz.

This bug is related with how much deep is the stack of __salt__ calls,
and do not clossing some connections to the master.

Tracking the AsyncZeroMQChannel connections to master:4506, we can see
that one is not closed once the actions ends, hanging the salt-call CLI.

This commit will be reverted once the root cause in found, and the bug
fixed.

(cherry picked from commit 2b833aa2f338b1f3f7107ab600c2067a10772ca4)
(cherry picked from commit 2b77f9f881957d4756cd1bb64408f49d71d79f70)
Based on the code from the SSH client wrapper, add apply_, sls and
highstate for the execution of Salt states inside a chroot environment.

(cherry picked from commit a239990efb1a74ab0045e9e9d6f31c1573462a42)
@aplanas
Copy link
Contributor Author

aplanas commented Apr 8, 2020

this was already merged upstream some time ago

Copy link
Member

@brejoc brejoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@meaksh meaksh force-pushed the openSUSE-2019.2.0 branch from 1417f49 to 0e0f1b7 Compare April 30, 2020 08:23
@agraul agraul merged commit bc51ecd into openSUSE:openSUSE-2019.2.0 May 12, 2020
@aplanas aplanas deleted the yomi_changes branch October 27, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants