Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osclib/list_command.py: Allow overriding reviews filter from the command line. #3186

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

gleidi-suse
Copy link
Contributor

@gleidi-suse gleidi-suse commented Oct 31, 2024

This patch implements overriding of the filter on reviews set up by the staging plugin. It is now possible to filter requests that have been reviewed by more than one group, for example; or to filter requests that have lack a request by a specific group or bot.

It allows queries like the following:

iosc staging -p SUSE:SLFO:Main list --match-filter "state/@name='review' and review[@by_group='factory-auto' and @state='new']"

or also

iosc staging -p SUSE:SLFO:Main list --match-filter "state/@name='review' and review[(@by_group='factory-auto' or @by_group='licensedigger') and @state='accepted']"

@gleidi-suse gleidi-suse force-pushed the filter_reviewers branch 4 times, most recently from e9905c6 to be4975d Compare November 7, 2024 10:10
Copy link
Member

@g7 g7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this nice feature! Just some minor nitpicks/questions

osc-staging.py Outdated Show resolved Hide resolved
osclib/stagingapi.py Outdated Show resolved Hide resolved
osc-staging.py Outdated Show resolved Hide resolved
Copy link
Member

@g7 g7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I have a small comment but it's not really an issue :) Tested, works fine for me.

osclib/stagingapi.py Outdated Show resolved Hide resolved
…and line.

This patch implements overriding of the filter on reviews set up by the
staging plugin. It is now possible to filter requests that have been
reviewed by more than one group, for example; or to filter requests that
have lack a request by a specific group or bot.
@gleidi-suse gleidi-suse merged commit ac74d91 into master Dec 4, 2024
11 checks passed
@gleidi-suse gleidi-suse deleted the filter_reviewers branch December 4, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants