[webui] Display worker capabilities on the monitor page #15689
Conversation
hmsf
force-pushed
the
display-worker-capabilities
branch
14 times, most recently
from
477e8a4 to
2ac2e40
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15689 +/- ##
==========================================
- Coverage 86.07% 86.06% -0.02%
==========================================
Files 793 794 +1
Lines 26020 25998 -22
==========================================
- Hits 22398 22375 -23
- Misses 3622 3623 +1 |
|
Hey @saraycp @rubhanazeem can you take a look at this please? Let me know if I missed something, I'll change it when I am able to. Thank you! |
| @@ -25,6 +25,7 @@ def ignore_link?(link) | |||
| return true if link.include?('/live_build_log/SourceprotectedProject') | |||
| return true if link.include?('/live_build_log/home:Iggy/ToBeDeletedTestPack') | |||
| return true if link.include?('/live_build_log') | |||
| return true if link.include?('/worker_capabilities') | |||
There was a problem hiding this comment.
Why do you ignore this route in the spider test?
There was a problem hiding this comment.
Hey @hennevogel appreciate the review! Spider was breaking on that link so I was thinking I should add an exception to it similar to the live_build_log link, but maybe there is a better way?
There was a problem hiding this comment.
I think the other way to make this work without excluding the link would be to somehow create the data on the backend. I see some examples in src/api/script/start_test_backend but I don't know the path and data to provide the backend connection with. Is there any doc I can take a look to learn more?
There was a problem hiding this comment.
The backend is already started in the spider test, so this can't be it.
src/api/app/controllers/webui/worker_capabilities_controller.rb
Outdated
Show resolved
Hide resolved
src/api/app/controllers/webui/worker_capabilities_controller.rb
Outdated
Show resolved
Hide resolved
src/api/spec/controllers/webui/worker_capabilities_controller_spec.rb
Outdated
Show resolved
Hide resolved
src/api/spec/controllers/webui/worker_capabilities_controller_spec.rb
Outdated
Show resolved
Hide resolved
hmsf
force-pushed
the
display-worker-capabilities
branch
5 times, most recently
from
59dd0a6 to
9679d19
Compare
exclude worker capabilities link from crawler
hmsf
force-pushed
the
display-worker-capabilities
branch
from
9679d19 to
6065537
Compare
|
Hey @hmsf , do you need help with this PR? |
Adds a new endpoint that renders a page with the given workers capabilities. A new link on the monitor page will then call this new endpoint.
#560