[api] fix release of package where source is remote or scmsync'd #15652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianschroeter
force-pushed
the
fix_package_release
branch
4 times, most recently
from
26d2c26 to
8626319
Compare
adrianschroeter
force-pushed
the
fix_package_release
branch
4 times, most recently
from
2a602f6 to
3910f06
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15652 +/- ##
==========================================
+ Coverage 86.00% 86.03% +0.02%
==========================================
Files 794 793 -1
Lines 26049 25973 -76
==========================================
- Hits 22404 22346 -58
+ Misses 3645 3627 -18 |
bugfinder
force-pushed
the
fix_package_release
branch
from
3910f06 to
8c1081d
Compare
|
Please let's do this once (#16226) and not in 100 different places... |
|
there are high chances that we may need this this or next week on build.opensuse.org as well. I would need to merge this then and you can rework it later. |
hennevogel
force-pushed
the
fix_package_release
branch
from
8c1081d to
af920f8
Compare
This was referenced Jul 15, 2024
Closed
|
handled differently in #16506 |
|
still crashing without this |
What is still crashing and where? |
adrianschroeter
force-pushed
the
fix_package_release
branch
2 times, most recently
from
8498ff6 to
cab39ac
Compare
adrianschroeter
force-pushed
the
fix_package_release
branch
from
cab39ac to
bbd0dbd
Compare
This creates a temporary package object which is not stored. We may track remote package objects in future but for now this temporary object seems to be the way to go.
adrianschroeter
force-pushed
the
fix_package_release
branch
from
bbd0dbd to
d5dceb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a temporary package object which is not stored. We may track remote package objects in future but for now this temporary object seems to be the way to go.