Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Event::CreateReport and related codepaths #15067

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove Event::CreateReport and related codepaths #15067

wants to merge 3 commits into from

Conversation

krauselukas
Copy link
Contributor

@krauselukas krauselukas commented Oct 16, 2023 •
edited
Loading

DO NOT MERGE: We have to first clean up the production database before safely deploying this PR

@krauselukas krauselukas added Frontend Things related to the OBS RoR app DO NOT MERGE ⚠️ Explain yourself if you add/remove this label to a PR labels Oct 16, 2023
@krauselukas krauselukas force-pushed the refactor/remove_deprecrated_create_report_event branch 3 times, most recently from 17d7351 to de7a15f Compare October 16, 2023 10:08
@krauselukas krauselukas force-pushed the refactor/remove_deprecrated_create_report_event branch from de7a15f to b1f126e Compare October 16, 2023 11:20
@krauselukas
Copy link
Contributor Author

Event::ReportCreate STIs (L)

@krauselukas krauselukas marked this pull request as ready for review October 16, 2023 13:53
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.92%. Comparing base (3b9c357) to head (6e827cc).
Report is 4083 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15067      +/-   ##
==========================================
+ Coverage   86.89%   86.92%   +0.02%     
==========================================
  Files         774      772       -2     
  Lines       25670    25644      -26     
==========================================
- Hits        22305    22290      -15     
+ Misses       3365     3354      -11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danidoni danidoni danidoni approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE ⚠️ Explain yourself if you add/remove this label to a PR Frontend Things related to the OBS RoR app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krauselukas @danidoni