Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add genomeprep link #538

Merged
merged 3 commits into from
Jul 26, 2022
Merged

add genomeprep link #538

merged 3 commits into from
Jul 26, 2022

Conversation

gedankenstuecke
Copy link
Member

Add link to repository with ~5,000 pre-processed and cleaned data sets to genotype page.

@philippbayer
Copy link
Member

Sorry I just saw this PR - is there a reason why the checks are hanging?

@tsujigiri
Copy link
Collaborator

@philippbayer I think Travis CI stopped offering their free tier. Not sure what's wrong with CodeClimate. I started setting up GitHub Actions for that, but apparently I forgot about it soon after. 😅

@philippbayer
Copy link
Member

I see :) Can we turn off these two checks then? Especially your PR changes just one line

@tsujigiri
Copy link
Collaborator

At your own risk! 😬 The problem is that TravisCI also built the Docker image. But I can do that locally.

@tsujigiri
Copy link
Collaborator

I turned off the failing checks.

@philippbayer
Copy link
Member

Thanks!!

AppVeyor has a open source free-tier, would it make sense to switch to them? https://www.appveyor.com/pricing/
or just use Github Actions like you started to?

@tsujigiri
Copy link
Collaborator

I'd go with GitHub Actions, since we don't need another account on another service for that. We just need to get it running...

@philippbayer
Copy link
Member

Failure/Error: expect(page).to have_content('Variations you did not enter yet (3)')
expected to find text "Variations you did not enter yet (3)" in "openSNP News Data Latest Data About Dogbert x Upload Your Genotyping File Upload the genotyping raw-data you got from 23andMe, deCODEme or FamilyTreeDNA to the openSNP database to share it with other personal-genomics customers and scientists from around the world. x Enter Your Variations Let us, and the other openSNP users, know some of your characteristics—like hair or eye color! Or how about some diseases? Whatever you feel like sharing!. x Enter a New Phenotype Got an idea for a phenotype that has not been asked about yet and that could have genetical roots? Great, you can add one to the openSNP database. xLogin successful! Hello, Dogbert Add your description Achievements Variations you did not enter yet (21)

Seems like the test fails because the DB does not get reset between tests any more? We expect 3 variations but the DB has 21

@tsujigiri
Copy link
Collaborator

@philippbayer Hmmm... Maybe it's leftover data from the old tests, running before the RSpec ones? 🤔 Let's try this.

@gedankenstuecke
Copy link
Member Author

Doh, of course that was the problem, thanks @tsujigiri!

@tsujigiri tsujigiri merged commit cb3d21b into master Jul 26, 2022
@tsujigiri tsujigiri deleted the genomeprep branch July 26, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants