Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rails (CVE-2018-16476) #516

Merged
merged 4 commits into from
Dec 6, 2018
Merged

Update rails (CVE-2018-16476) #516

merged 4 commits into from
Dec 6, 2018

Conversation

tsujigiri
Copy link
Collaborator

No description provided.

@philippbayer
Copy link
Member

Does the test suddenly fail because of a new \n \r \r\n issue that wasn't there before?

@tsujigiri
Copy link
Collaborator Author

Yes. They seem to have changed to formatting of emails. I hope it's fixed now.

@philippbayer
Copy link
Member

philippbayer commented Dec 6, 2018 •
edited
Loading 

LoadError: cannot load such file -- shoulda-context

It seems to have fixed the other issue though?

@tsujigiri
Copy link
Collaborator Author

Of course... 🤔

@philippbayer philippbayer merged commit dba75c2 into master Dec 6, 2018
@philippbayer
Copy link
Member

👍 thank you!!

@tsujigiri
Copy link
Collaborator Author

🎉

@tsujigiri tsujigiri deleted the update-rails branch December 6, 2018 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippbayer philippbayer Awaiting requested review from philippbayer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsujigiri @philippbayer