Circumvents issue with endless refreshing on #messages tab #512
Conversation
app/views/layouts/_navbar.html.erb
Outdated
| @@ -43,7 +43,7 @@ | |||
| <li><%= link_to("Settings", "/users/"+current_user.id.to_s+"/edit", class: "navbar-menu__options", :id => current_user) %></li> | |||
| <li><%= link_to("Edit Your Phenotypes", "/users/"+current_user.id.to_s+"/edit#phenotypes", class: "navbar-menu__options")%></li> | |||
| <li class="divider"></li> | |||
| <li><%= link_to("Messages ("+current_user.messages.where(:user_has_seen => false).length.to_s+")","/users/" + current_user.id.to_s + "#messages", :method => "get", class: "navbar-menu__options")%></li> | |||
| <li><%= link_to "Messages (#{current_user.messages.where(:user_has_seen => false).length})","/users/#{current_user.id}#messages", class: 'navbar-menu__options', :data => { :reload => true }%></li> | |||
There was a problem hiding this comment.
"/users/#{current_user.id}#messages" can be written as user_path(current_user, anchor: 'messages')*. And I suppose the :data => { :reload => true } might have something to do with the reloading? 😄
* https://api.rubyonrails.org/classes/ActionView/Helpers/UrlHelper.html#method-i-link_to
There was a problem hiding this comment.
Yeah the :method => "get" causes an endless reload on my end (right now on production too), Firefox 62.0.3 - when I force the reload then the entire page reloads, but only once! and it lands on the correct tab
There was a problem hiding this comment.
Which :method => "get"? I don't think it has anything to do with the link. It happens if you put https://www.opensnp.org/users/15#messages into your address bar as well. This looks a bit suspicious.
There was a problem hiding this comment.
By method => get I mean the current way it's implement on production -
That JS snippet is definitely the main 'suspect', getting stuck in an endless loop - let me fix that. My forced reloading seems to not have triggered that JS, thereby circumventing it (on my system?)
There was a problem hiding this comment.
I think what's missing in the JS is comparing hash with anchor and only redirecting if they don't match.
There was a problem hiding this comment.
What's weird is, that it only does that on the messages tab in the first place. 🤔
There was a problem hiding this comment.
and why does this break only now? I put it in a year ago :P
There was a problem hiding this comment.
This is how to do the tab thing properly, according to the docs.
$('#myTabs a[href="#profile"]').tab('show')There was a problem hiding this comment.
I've put in a new commit which gets rid of the method: get, and now it seems to work, even with the 'old' JS?
|
🤷♂️ computers! thank you for your help :) |
Have a look - does it work on your ends too?
Could fix #425