Should return 404 for non-existing users/phenotypes/snps

app/controllers/application_controller.rb

@@ -7,6 +7,10 @@ class ApplicationController < ActionController::Base
       ssl_allowed :all
   end
 
+  def not_found
+      raise ActionController::RoutingError.new("Not found")
+  end
+
   private
 
   def current_user_session

app/controllers/phenotypes_controller.rb

@@ -113,7 +113,7 @@ class VariationRecommender < Recommendify::Base
   def show
     #@phenotypes = Phenotype.where(:user_id => current_user.id).all
     #@title = "Phenotypes"
-    @phenotype = Phenotype.find(params[:id])
+    @phenotype = Phenotype.find(params[:id]) || not_found
     @comments = PhenotypeComment.where(:phenotype_id => params[:id]).all(:order => "created_at ASC")
     @phenotype_comment = PhenotypeComment.new
     @user_phenotype = UserPhenotype.new

app/controllers/snps_controller.rb

@@ -13,7 +13,7 @@ def index
 	end
 
 	def show
-		@snp = Snp.find_by_name(params[:id].downcase)
+		@snp = Snp.find_by_name(params[:id].downcase) || not_found
 		@title = @snp.name
 		@comments = SnpComment.where(:snp_id => @snp.id).all(:order => "created_at ASC")
 		@users = User.find(:all, :conditions => { :user_snp => { :snps => { :id => @snp.id }}}, :joins => [ :user_snps => :snp])
@@ -190,7 +190,7 @@ def json_element(params)
     end
 
     def find_snp
-      @snp = Snp.find(params[:id].downcase)
+      @snp = Snp.find(params[:id].downcase) || not_found
 
       # If an old id or a numeric id was used to find the record, then
       # the request path will not match the post_path, and we should do

app/controllers/users_controller.rb

@@ -75,7 +75,7 @@ def index
 
   def show
     # showing a single user's page
-    @user = User.find_by_id(params[:id])
+    @user = User.find_by_id(params[:id]) || not_found
     @title = @user.name + "'s page"
     @first_name = @user.name.split.first
     @user_phenotypes = @user.user_phenotypes

serverscript

@@ -1,6 +1,6 @@
 #/bin/bash
 
-screen -d -m -S "Server" bundle exec rails s
+screen -d -m -S "Server" bundle exec rails s -e production
 screen -d -m -S "Solr" bundle exec rake sunspot:solr:run
 screen -d -m -S "Redis" redis-server
 screen -d -m -S "Resque-worker" bundle exec rake environment resque:work QUEUE=*