Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sed-Script for Adios Check #20

Closed
wants to merge 1 commit into from
Closed

sed-Script for Adios Check #20

wants to merge 1 commit into from

Conversation

michaelsippel
Copy link

Convert checkOpenPMD_h5.py with sed for adios.

@michaelsippel michaelsippel changed the title sed script for adios check sed-Script for Adios Check Jul 15, 2016
sed -e 's/h5py/adios/g' \
-e 's/\.h5/\.bp/g' \
-e 's/h5/ad/g' \
-e "s/ad.is_hdf5.*(\(.*\))/\1.endswith('.bp')/g" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

@ax3l
Copy link
Member

ax3l commented Jul 15, 2016

solves #1

@ax3l ax3l self-assigned this Jul 15, 2016
@ax3l
Copy link
Member

ax3l commented Jul 17, 2016

runtime checks: to do on the ADIOS numpy wrapper side:

[WARN] Invalid read method name: r . Use default BP method
Error: Attribute openPMD (required) does NOT exist in `simDataAdios_0.bp`!
[...]
  • attribute type checks fail in test_attr
[WARN] Invalid read method name: r . Use default BP method
Error: Attribute /openPMD in `simDataAdios_0.bp` is not of type '<map object at 0x7ff1a1c5b6a0>' (is 'attr')!
[...]
  • attributes need .value access to get ndarray and are currently always ndarray even for scalars Numpy: Scalar Attributes ornladios/ADIOS#79
  • string are falsely declared as vlen strings (np.str) instead of np.string_
  • uint32, unt64 types vs unprecise "long", "float", ... types
  • groups have no ".name" attribute and the File objects .name does not point to root / but gives the file name... (which should be f.filename instead)
  • groups do list all .keys() recursively instead of only lusting the next level Numpy: Group .keys() Attribute ornladios/ADIOS#72

-e 's/\.h5/\.bp/g' \
-e 's/h5/ad/g' \
-e "s/ad.is_hdf5.*(\(.*\))/\1.endswith('.bp')/g" \
-e 's/, "w"//g' \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

's/, "r"//g'

@ax3l
Copy link
Member

ax3l commented Nov 24, 2017

we keep PR for reference but changed the branch for now.
Also, there will be/is a new ADIOS2 Python API that we can use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants