Fix ADIOS1: listSeries #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
commented
Jan 5, 2021
| @@ -1112,8 +1112,7 @@ void test_complex(const std::string & backend) { | |||
| if( backend != "json" ) //! @todo clarify that complex data is not N+1 data in JSON | |||
| { | |||
| Series list{ "../samples/serial_write_complex." + backend, Access::READ_ONLY }; | |||
| if( list.backend() != "ADIOS1" ) // FIXME: "Internal error: Failed to inquire about ADIOS variable during dataset opening" | |||
| helper::listSeries( list ); | |||
| helper::listSeries( list ); | |||
There was a problem hiding this comment.
[ADIOS1] Internal error: Failed to inquire about ADIOS variable
'/data/0/meshes/CfltCflt' during dataset opening
Curious, since it should only have a problem with Cldbl, which we don't write.
Looks like it doubled the variable name in the path: CfltCflt instead of Cflt?
ax3l
commented
Jan 5, 2021
test/SerialIOTest.cpp
Outdated
| @@ -1536,8 +1535,7 @@ TEST_CASE( "patch_test", "[serial]" ) | |||
| if( t != "json" ) // FIXME: "[JSON] No such attribute in the given location." | |||
| { | |||
| Series list{"../samples/serial_patch." + t, Access::READ_ONLY}; | |||
| if( list.backend() != "ADIOS1" ) // FIXME: "Internal error: Failed to inquire about ADIOS variable during dataset opening" | |||
| helper::listSeries(list); | |||
| helper::listSeries(list); | |||
There was a problem hiding this comment.
Same curious variable-name doubling here (xx should read x):
[ADIOS1] Internal error: Failed to inquire about ADIOS variable
'/data/1/particles/e/particlePatches/offset/xx' during dataset opening
Cover ADIOS1 issue on listSeries seen with two tests.
ax3l
force-pushed
the
fix-listSeriesADIOS1
branch
from
86a3dae to
9e942aa
Compare
Add the missing variable name to the error message.
ax3l
force-pushed
the
fix-listSeriesADIOS1
branch
from
9e942aa to
53cb2a6
Compare
|
This seems to be essentially the same issue as in #884. Apparently, our tests didn't yet cover workflows where a dataset is opened twice and the JSON and ADIOS1 backends did not deal with that correctly. |
|
Epic, thank you! ✨ |
franzpoeschel
added a commit
to franzpoeschel/openPMD-api
that referenced
this pull request
Jan 29, 2021
* Test ADIOS1: listSeries Cover ADIOS1 issue on listSeries seen with two tests. * ADIOS1: More Meaningful Var Error Msg Add the missing variable name to the error message. * ADIOS1: deal correctly with opening datasets multiple times Co-authored-by: Franz Pöschel <franz.poeschel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ADIOS1 issue on listSeries seen with two tests.