Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build System Support for JSON Backend #384

Merged
merged 5 commits into from
Nov 2, 2018
Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Nov 2, 2018

Adds build system support for the upcoming JSON backend in #338.

  • CMake: JSON support
  • vendored third party libs: add nlohmann-json 3.4.0
  • Travis: adds coverage so we can also turn JSON off.
  • Python: allow to query if JSON variant is compiled in.
  • Docs: document new backend options, version & license of vendored lib.

@ax3l ax3l added third party third party libraries that are shipped and/or linked backend: JSON frontend: Python3 continuous integration api: new additions to the API labels Nov 2, 2018
@franzpoeschel franzpoeschel mentioned this pull request Nov 2, 2018
6 tasks
nlohmann and others added 4 commits November 2, 2018 10:41
Add only single-header variant and CMake scripts.
Remove EOL white-spaces in CMakeList.txt
Add options and internal vendoring control for new JSON backend.
Remove JSON support from one build in the matrix.
This adds coverage so we can truely turn it off.
Add support for querying if the JSON backend is compiled.
@ax3l ax3l force-pushed the topic-vendorJSON branch from 90b9787 to ec8836a Compare November 2, 2018 09:42
@ax3l ax3l force-pushed the topic-vendorJSON branch from 01c1d9e to ee5e142 Compare November 2, 2018 10:12
@ax3l ax3l merged commit 676ac4b into openPMD:dev Nov 2, 2018
@ax3l ax3l deleted the topic-vendorJSON branch November 2, 2018 11:28
@ax3l ax3l restored the topic-vendorJSON branch November 2, 2018 11:29
@ax3l ax3l deleted the topic-vendorJSON branch November 2, 2018 11:29
@ax3l ax3l mentioned this pull request Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: new additions to the API backend: JSON continuous integration frontend: Python3 third party third party libraries that are shipped and/or linked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants