Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown openPMD version: Add upgrade hint #1528

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

franzpoeschel
Copy link
Contributor

Adding this now so users have an instructive upgrade message once we hit openPMD 2.0.

@franzpoeschel franzpoeschel added this to the 0.15.3 milestone Sep 8, 2023
@franzpoeschel franzpoeschel merged commit 8b08736 into openPMD:dev Sep 11, 2023
@franzpoeschel franzpoeschel deleted the upgrade-message branch September 11, 2023 14:43
@ax3l ax3l self-requested a review October 6, 2023 23:35
@ax3l
Copy link
Member

ax3l commented Oct 6, 2023

LGTM :)

@ax3l
Copy link
Member

ax3l commented Oct 6, 2023

Btw, I have a define in version.hpp that knows the highest currently supported version numbers.

So, technically speaking, we could give this guidance:

  • version too old: downgrade
  • version too new: upgrade
  • version corrupted format: print and reach out to data source

eschnett added a commit to eschnett/openPMD-api that referenced this pull request Oct 13, 2023
* dev:
  [pre-commit.ci] pre-commit autoupdate (openPMD#1536)
  Fix double mesh.read() call (openPMD#1535)
  Python 3.12: Remove Distutils (openPMD#1508)
  openpmd-pipe: fix handling of constant components (openPMD#1530)
  Bug fix: Linear read mode cannot directly access specific file of file-based Series (openPMD#1533)
  Unknown openPMD version in data: Add upgrade hint (openPMD#1528)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants