Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adios2 warn groupbased encoding #1498

Merged
merged 15 commits into from
Dec 22, 2023
Merged

Adios2 warn groupbased encoding #1498

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d78fb0e
Warning: group-based iteration encoding in ADIOS2
franzpoeschel Aug 8, 2023
d7a6948
Remove adios2.usesteps, set it always to true
franzpoeschel Oct 18, 2023
daecb3b
Remove requireActiveStep
franzpoeschel Oct 19, 2023
d4a81ca
Remove StreamStatus::Parsing
franzpoeschel Oct 19, 2023
52fbe11
Remove usesteps = true/false from tests
franzpoeschel Oct 20, 2023
9fd89fd
Fix CI error
franzpoeschel Oct 23, 2023
5a77e64
Testing: ADIOS2 < v2.9 compatibility
franzpoeschel Oct 23, 2023
1df1b01
Less misleading warning message
franzpoeschel Oct 23, 2023
93ca7a7
Unify struct/class
franzpoeschel Nov 17, 2023
b50f5f2
Transition a bit more leniently (part 1)
franzpoeschel Dec 19, 2023
196fdd9
Transition a bit more leniently (part 2)
franzpoeschel Dec 19, 2023
cf7c759
Remove usesteps option from documentation
franzpoeschel Dec 19, 2023
2cf9aab
Cleanup and fixes
franzpoeschel Dec 21, 2023
70df57a
Fix tests
franzpoeschel Dec 22, 2023
961366a
Fix the warning text
franzpoeschel Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
@franzpoeschel
franzpoeschel committed Dec 22, 2023
commit 70df57aa653d604a4d7596918dd082b65fa2dfcf
11 changes: 9 additions & 2 deletions test/SerialIOTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4880,15 +4880,22 @@ void bp4_steps(

TEST_CASE("bp4_steps", "[serial][adios2]")
{
std::string bp4 = R"(
std::string bp4 = json::merge(
R"(
{
"ADIOS2": {
"engine": {
"type": "bp4"
}
}
}
)";
)",
#if openPMD_HAS_ADIOS_2_9
R"({"ADIOS2":{"use_group_table": true}})"
#else
R"({"ADIOS2":{"use_group_table": false}})"
#endif
);
std::string nullcore = R"(
{
"adios2": {
Expand Down