Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++17 #1164

Merged
merged 18 commits into from
Jan 24, 2022
Merged

C++17 #1164

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
cf8db69
Remove: MPark.Variant (internal)
ax3l Jan 11, 2022
0bdcbb5
CMake: C++17
ax3l Jan 11, 2022
5aedf38
Docs: w/o MPark.Variant
ax3l Jan 11, 2022
551c410
Docs: C++17
ax3l Jan 11, 2022
d9b3552
Remove C++14-only Code
ax3l Jan 11, 2022
9eeffb6
Variant/Option: only `std::variant` as source
ax3l Jan 11, 2022
98f32b2
CI: Clang 5->6, GCC 5->7
ax3l Jan 11, 2022
4301f96
Clang6: Ubuntu 20.04
ax3l Jan 11, 2022
7b76370
clang-tidy-10: namespace & nodiscard
ax3l Jan 12, 2022
ff21f05
macOS: raise deployment target to 10.13
ax3l Jan 12, 2022
eb7d89b
clang6 on Linux: use libc++
ax3l Jan 12, 2022
09674fc
Add a Clang 7 build
ax3l Jan 12, 2022
7b6ccf9
add libc++abi-dev
ax3l Jan 12, 2022
615d488
Clang 6: `-Wno-ignored-attributes -Wno-unused-const-variable`
ax3l Jan 14, 2022
f43ccb1
README: C++17 Structure Bindings
ax3l Jan 15, 2022
43da126
Doc: Support Clang 7+
ax3l Jan 20, 2022
d487461
C++17: Replace auxiliary::Option with std::optional
franzpoeschel Jan 24, 2022
8a364f6
Remove SFINAE in some places (#3)
franzpoeschel Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove C++14-only Code
  • Loading branch information
@ax3l
ax3l committed Jan 24, 2022
commit d9b35529c2789699c455155611980854535a8eb4
35 changes: 0 additions & 35 deletions include/openPMD/auxiliary/Unused.hpp
View file
Open in desktop

This file was deleted.

12 changes: 2 additions & 10 deletions src/IO/ADIOS/ADIOS2IOHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1359,11 +1359,7 @@ namespace detail
* that would otherwise be lost. Check whether this has been done.
*/
using rep = AttributeTypes< bool >::rep;
if
#if __cplusplus >= 201703L
constexpr
#endif
( std::is_same< T, rep >::value )
if constexpr( std::is_same< T, rep >::value )
{
std::string metaAttr =
ADIOS2Defaults::str_isBooleanOldLayout + name;
Expand Down Expand Up @@ -1414,11 +1410,7 @@ namespace detail
* that would otherwise be lost. Check whether this has been done.
*/
using rep = AttributeTypes<bool>::rep;
if
#if __cplusplus >= 201703L
constexpr
#endif
( std::is_same< T, rep >::value )
if constexpr( std::is_same< T, rep >::value )
{
std::string metaAttr =
ADIOS2Defaults::str_isBooleanNewLayout + name;
Expand Down
7 changes: 3 additions & 4 deletions src/auxiliary/Filesystem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
*/
#include "openPMD/auxiliary/Filesystem.hpp"
#include "openPMD/auxiliary/StringManip.hpp"
#include "openPMD/auxiliary/Unused.hpp"

#ifdef _WIN32
# include <windows.h>
Expand Down Expand Up @@ -200,11 +199,11 @@ namespace
* Only some of these are actually instanciated,
* so suppress warnings for the others.
*/
OPENPMDAPI_UNUSED
[[maybe_unused]]
ax3l marked this conversation as resolved.
Show resolved Hide resolved
MPI_Datatype const MPI_Types< unsigned >::value = MPI_UNSIGNED;
OPENPMDAPI_UNUSED
[[maybe_unused]]
MPI_Datatype const MPI_Types< unsigned long >::value = MPI_UNSIGNED_LONG;
OPENPMDAPI_UNUSED
[[maybe_unused]]
MPI_Datatype const MPI_Types< unsigned long long >::value = MPI_UNSIGNED_LONG_LONG;
} // namespace

Expand Down