Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.14.3 backports #1135

Merged
merged 19 commits into from
Nov 4, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
NVCC + C++17 (#1103)
* NVCC + C++17

Work-around a build issue with NVCC in C++17 builds.
```
include/openPMD/backend/Attributable.hpp(437):
error #289: no instance of constructor "openPMD::Attribute::Attribute" matches the argument list
            argument types are: (std::__cxx11::string)
          detected during instantiation of "__nv_bool openPMD::AttributableInterface::setAttribute(const std::__cxx11::string &, T) [with T=std::__cxx11::string]"
```
from
```
inline bool
AttributableInterface::setAttribute( std::string const & key, char const value[] )
{
    return this->setAttribute(key, std::string(value));
}
```

Seen with:
- NVCC 11.0.2 + GCC 8.3.0
- NVCC 11.0.2 + GCC 7.5.0

* NVCC 11.0.2 C++17 work-around: Add Comment
  • Loading branch information
ax3l committed Nov 3, 2021
commit 3b647f8dc35567bc04ad6817b37d5831423e451d
7 changes: 6 additions & 1 deletion include/openPMD/backend/Attributable.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,12 @@ AttributableInterface::setAttribute( std::string const & key, T value )
&& !attri.m_attributes.key_comp()(key, it->first) )
{
// key already exists in map, just replace the value
it->second = Attribute(value);

// note: due to a C++17 issue with NVCC 11.0.2 we write the
// T value to variant conversion explicitly
// https://github.com/openPMD/openPMD-api/pull/1103
//it->second = Attribute(std::move(value));
it->second = Attribute(Attribute::resource(std::move(value)));
return true;
} else
{
Expand Down