Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDF5 I/O optimizations #1129

Merged
merged 11 commits into from
Oct 27, 2021
Merged

HDF5 I/O optimizations #1129

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
04df77e
Include HDF5 optimization options
jeanbez Oct 19, 2021
d5c2232
Merge branch 'openPMD:dev' into hdf5-io-tuning
jeanbez Oct 19, 2021
b4bdc5b
Fix code style check
jeanbez Oct 19, 2021
51aa3f9
Fix validations and include checks
jeanbez Oct 20, 2021
cee8858
Fix style check
jeanbez Oct 20, 2021
ff31e04
Remove unecessary strict check
jeanbez Oct 20, 2021
e45e4b8
Update documentation with HDF5 tuning options
jeanbez Oct 20, 2021
469eb69
Update contributions
jeanbez Oct 20, 2021
983729d
Fix Guards for H5Pset_all_coll_metadata*
ax3l Oct 22, 2021
ae99116
MPI Guard: H5Pset_all_coll_metadata*
ax3l Oct 22, 2021
fa4e034
Remove duplicated variable
jeanbez Oct 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unecessary strict check
  • Loading branch information
@jeanbez
jeanbez committed Oct 20, 2021
commit ff31e04df21d2106c69e24b70cb28b88ebec7d1f
4 changes: 0 additions & 4 deletions src/IO/HDF5/ParallelHDF5IOHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,6 @@ ParallelHDF5IOHandlerImpl::ParallelHDF5IOHandlerImpl(
auto const hdf5_collective_metadata = auxiliary::getEnvString( "OPENPMD_HDF5_COLLECTIVE_METADATA", "ON" );
if( hdf5_collective_metadata == "OFF" )
collective_metadata = 0;
else
{
VERIFY(hdf5_collective_metadata == "OFF", "[HDF5] Internal error: OPENPMD_HDF5_COLLECTIVE_METADATA property must be either ON or OFF");
}

ax3l marked this conversation as resolved.
Show resolved Hide resolved
status = H5Pset_all_coll_metadata_ops(m_fileAccessProperty, collective_metadata);
VERIFY(status >= 0, "[HDF5] Internal error: Failed to set metadata read HDF5 file access property");
Expand Down