Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: Use Series::writeIterations() without explicit flushing #1030

Merged
merged 3 commits into from
Jul 8, 2021
Merged

Bug fix: Use Series::writeIterations() without explicit flushing #1030

merged 3 commits into from
Jul 8, 2021

Conversation

franzpoeschel
Copy link
Contributor

@franzpoeschel franzpoeschel commented Jul 7, 2021 •
edited
Loading

First commit adds a failing test
Second commit will add a fix

Probably related: #994

ax3l
ax3l approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

ax3l
ax3l reviewed Jul 8, 2021
View reviewed changes
test/SerialIOTest.cpp Outdated Show resolved Hide resolved
@ax3l ax3l enabled auto-merge (squash) July 8, 2021 00:39
@ax3l ax3l mentioned this pull request Jul 8, 2021
Open
@ax3l ax3l merged commit 358e25a into openPMD:dev Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@eschnett eschnett

@ax3l ax3l

Labels
affects latest release bug frontend: C++17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franzpoeschel @ax3l @eschnett