WEB-689: Fix Spanish Translation #3121
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Note
|
| Cohort / File(s) | Summary |
|---|---|
Translation terminology updates src/assets/translations/es-CL.json, src/assets/translations/es-MX.json |
Systematic content updates: "Loan"/"Préstamo" → "Crédito"/"Crédito", "Loan Product" → "Producto de Crédito", "Loans" → "Créditos", "Loan Transactions" → "Transacciones de Crédito", "Loan Provisioning" → "Provisionamiento de Crédito", plus related noun and entity label adjustments (e.g., "Entity"/"Tenant" → "Persona Moral"/"Entidad") across catalogs, tooltips, dialogs, audit entries, and UI labels. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
- IOhacker
- steinwinde
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately reflects the main change: updating Spanish translations in two locale files (es-CL.json and es-MX.json) with loan-to-credit terminology shifts and entity label adjustments. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
EmanuelCR03
force-pushed
the
fix-spanish
branch
from
da0cbd1 to
1672c5d
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/assets/translations/es-MX.json (1)
2138-2138:⚠️ Potential issue | 🟡 MinorReplace “colateral/colaterales” with “garantía(s)”.
These two entries still use “colateral”, which conflicts with the established es‑MX glossary.📝 Suggested fixes
- "Number of Collaterals": "Número de colaterales", + "Number of Collaterals": "Número de garantías", ... - "Collateral": "Colateral", + "Collateral": "Garantía",Based on learnings “In the Spanish (es-MX) translations, use 'garantía' for singular and 'garantías' for plural instead of 'colateral'. Update es-MX.json accordingly and search for all occurrences of 'colateral' in that locale to replace with the correct forms. Ensure pluralization handles different contexts where appropriate.”
Also applies to: 2956-2956
🤖 Fix all issues with AI agents
In `@src/assets/translations/es-CL.json`:
- Line 1095: The Spanish translation for the key "Loan Delinquency
Classification" uses "delincuencia" which is incorrect; update the value to use
"morosidad" instead (e.g., change "Clasificación de delincuencia de créditos" to
"Clasificación de morosidad de créditos" or equivalent) so it matches other
strings and correct terminology for loan delinquency.
- Line 1099: Replace the inconsistent Spanish translation for the key/value
where "Loan Disbursal" is currently translated as "Curso de créditos" with
"Desembolso de créditos"; search for other occurrences like "Curso del Crédito"
and consolidate them to the same phrasing ("Desembolso de créditos") so all
"Loan Disbursal" usages share the identical translation.
- Line 1292: Replace Mexican legal terms with Chilean ones: find occurrences of
"persona moral" and "persona física" in this translations file (e.g., the value
for the "Entity Details" key and the other flagged entries) and change "persona
moral" -> "persona jurídica" and "persona física" -> "persona natural"; update
all corresponding translated values at the flagged locations (and any other
entries using those phrases) so the JSON uses Chilean legal terminology
consistently.
In `@src/assets/translations/es-MX.json`:
- Around line 1094-1106: Replace the inconsistent term "delincuencia" with the
established "morosidad" in the Loan Delinquency keys (e.g., "Loan Delinquency
Classification", "Loan Delinquency Tags", "Loan Delinquency Installment Tags")
so they match the existing phrasing used elsewhere (see the label at line ~807),
and make pluralization consistent for disbursal/reschedule labels (ensure "Loan
Disbursal" and "Loan Reschedule" translations use the same plurality as the rest
of the loan labels, e.g., "Desembolso de créditos" and "Reprogramación de
créditos"); apply the same fixes to the other occurrence mentioned (around line
1121).
- Line 2484: The translation for the "Tenant App Key" key uses an incorrect term
("Persona Moral"); update the value to use the instance/tenant wording
consistent with other entries (e.g., change the value for "Tenant App Key" to
"Clave de aplicación para la instancia") so it matches earlier "Instancia"
usage.
| "Loan Details": "Detalles del Crédito", | ||
| "Loan Disbursal": "Curso de préstamos", | ||
| "Loan Originators": "Originadores de préstamos", | ||
| "Loan Disbursal": "Curso de créditos", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, let's verify the exact content at line 1099 of es-CL.json
sed -n '1095,1105p' src/assets/translations/es-CL.jsonRepository: openMF/web-app
Length of output: 695
🏁 Script executed:
# Search for other uses of "desembolso" or "Desembolso" in es-CL.json to verify the inconsistency claim
rg -i "desembolso" src/assets/translations/es-CL.json -C 2Repository: openMF/web-app
Length of output: 5145
🏁 Script executed:
# Also check for "Loan Disbursal" references in es-CL.json to see if there are multiple occurrences
rg "Loan Disbursal" src/assets/translations/es-CL.jsonRepository: openMF/web-app
Length of output: 192
Use "Desembolso de créditos" for consistency with existing terminology.
The translation "Curso de créditos" is inconsistent with how disbursement-related terms are translated throughout the file. Multiple existing strings already use "desembolso" (e.g., "Habilitar múltiples desembolsos" for "Enable Multiple Disbursals", "Número máximo de desembolsos" for "Maximum Tranche count"). Note: "Loan Disbursal" also appears elsewhere in the file as "Curso del Crédito"; consider consolidating all occurrences to use "Desembolso de créditos" for consistency.
Suggested fix
- "Loan Disbursal": "Curso de créditos",
+ "Loan Disbursal": "Desembolso de créditos",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "Loan Disbursal": "Curso de créditos", | |
| "Loan Disbursal": "Desembolso de créditos", |
🤖 Prompt for AI Agents
In `@src/assets/translations/es-CL.json` at line 1099, Replace the inconsistent
Spanish translation for the key/value where "Loan Disbursal" is currently
translated as "Curso de créditos" with "Desembolso de créditos"; search for
other occurrences like "Curso del Crédito" and consolidate them to the same
phrasing ("Desembolso de créditos") so all "Loan Disbursal" usages share the
identical translation.
| "Template Message": "Mensaje de plantilla", | ||
| "Tenant": "Entidad", | ||
| "Tenant": "Persona Moral", | ||
| "Tenant App Key": "Clave de aplicación para la entidad", |
There was a problem hiding this comment.
“Tenant” shouldn’t be translated as “Persona Moral”.
This label refers to the instance/tenant, not a legal entity. Consider matching the earlier “Instancia” usage.
🔧 Suggested fix
- "Tenant": "Persona Moral",
+ "Tenant": "Instancia",🤖 Prompt for AI Agents
In `@src/assets/translations/es-MX.json` at line 2484, The translation for the
"Tenant App Key" key uses an incorrect term ("Persona Moral"); update the value
to use the instance/tenant wording consistent with other entries (e.g., change
the value for "Tenant App Key" to "Clave de aplicación para la instancia") so it
matches earlier "Instancia" usage.
2 participants
Description
WEB-689: Fix Spanish Translation
Related issues and discussion
#{Issue Number}
Screenshots, if any
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.Summary by CodeRabbit