Skip to content

WEB-679 Fix Translation key not resolving in provisioning criteria definition dialog#3109

Merged
IOhacker merged 1 commit intoopenMF:devfrom
JaySoni1:WEB-679-fix-translation-key-not-resolving-in-provisioning-criteria-definition-dialog
Feb 9, 2026
Merged

WEB-679 Fix Translation key not resolving in provisioning criteria definition dialog#3109
IOhacker merged 1 commit intoopenMF:devfrom
JaySoni1:WEB-679-fix-translation-key-not-resolving-in-provisioning-criteria-definition-dialog

Conversation

@JaySoni1
Copy link
Contributor

@JaySoni1 JaySoni1 commented Feb 9, 2026

Changes Made :-

-Changed the translation key from :- labels.heading.Edit Criteria Definition to labels.buttons.Edit Criteria Definition

WEB-679

Before :-

image

After :-

image

Summary by CodeRabbit

  • Bug Fixes
    • Updated dialog title labels for loan provisioning criteria dialogs to use the correct text identifier, ensuring consistent labeling across create and edit operations.

@coderabbitai
Copy link

coderabbitai bot commented Feb 9, 2026

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

Translation key updated from labels.heading.Edit Criteria Definition to labels.buttons.Edit Criteria Definition in the dialog title configuration for two loan provisioning criteria components.

Changes

Cohort / File(s) Summary
Translation Key Update
src/app/organization/loan-provisioning-criteria/create-loan-provisioning-criteria/create-loan-provisioning-criteria.component.ts, src/app/organization/loan-provisioning-criteria/edit-loan-provisioning-criteria/edit-loan-provisioning-criteria.component.ts
Updated translation key in editDefinition() method from labels.heading.Edit Criteria Definition to labels.buttons.Edit Criteria Definition for dialog title.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • alberto-art3ch
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: correcting a translation key reference in the provisioning criteria definition dialog across two component files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IOhacker IOhacker merged commit 96eafba into openMF:dev Feb 9, 2026
5 checks passed
@JaySoni1
Copy link
Contributor Author

JaySoni1 commented Feb 9, 2026

@IOhacker Thank You for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants