Skip to content

WEB-611: Add charge option menu loan overpaid#3027

Merged
alberto-art3ch merged 1 commit intoopenMF:devfrom
alberto-art3ch:WEB-611/add-charge-option-menu-loan-overpaid
Jan 21, 2026
Merged

WEB-611: Add charge option menu loan overpaid#3027
alberto-art3ch merged 1 commit intoopenMF:devfrom
alberto-art3ch:WEB-611/add-charge-option-menu-loan-overpaid

Conversation

@alberto-art3ch
Copy link
Collaborator

@alberto-art3ch alberto-art3ch commented Jan 21, 2026

Description

Add charge option is available via BE, so while execute POS/loans/{loanId}/charges withy valid data - success result and added charge is shown

WEB-611

Related issues and discussion

Screenshots, if any

Screenshot 2026-01-20 at 11 04 11 p m

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

  • New Features
    • Added "Add Loan Charge" button for overpaid loan accounts, enabling users to create loan charges directly from the loan view.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

A new "Add Loan Charge" button is added to the loan accounts button configuration for the 'Overpaid' status, providing users with the ability to create a loan charge when a loan is in the overpaid state.

Changes

Cohort / File(s) Summary
Loan Button Configuration
src/app/loans/loans-view/loan-accounts-button-config.ts
Adds a new button entry ("Add Loan Charge" with plus icon) to the beginning of the buttonsArray when loan status is 'Overpaid', requiring CREATE_LOANCHARGE permission

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • steinwinde
  • gkbishnoi07
  • adamsaghy
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'WEB-611: Add charge option menu loan overpaid' is clear and directly describes the main change—adding a charge menu option for overpaid loans, which matches the file changes and PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alberto-art3ch alberto-art3ch merged commit 3f95623 into openMF:dev Jan 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants