WEB-594 Translate breadcrumbs account transfers using the i-18-n translation-key#3008
Conversation
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Routing Configuration src/app/account-transfers/account-transfers-routing.module.ts |
Updates breadcrumb from hardcoded "Account Transfers" string to translation key 'labels.breadcrumbs.Account Transfers' in route data |
Translation Files src/assets/translations/cs-CS.json, de-DE.json, en-US.json, es-CL.json, es-MX.json, fr-FR.json, it-IT.json, ko-KO.json, lt-LT.json, lv-LV.json, ne-NE.json, pt-PT.json, sw-SW.json |
Adds new breadcrumb translation entry for "Account Transfers" with language-specific translations and adjusts JSON syntax (trailing commas) |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
Possibly related PRs
- WEB-521 fix(i18n): add missing translations and apply translate pipes across … #2934: Both PRs modify breadcrumb translations for the Account Transfers route, applying internationalization changes to routing configuration and translation files.
Suggested reviewers
- IOhacker
- gkbishnoi07
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title 'WEB-594 Translate breadcrumbs account transfers using the i-18-n translation-key' clearly and specifically summarizes the main change: replacing a hardcoded breadcrumb label with an i18n translation key. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
- 📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/assets/translations/lt-LT.json`:
- Around line 309-310: The Lithuanian translations use two different terms for
account transfer concepts — the "Account Transfers" key (breadcrumbs) currently
set to "Sąskaitų pervedimai" and the "labels.catalogs" key set to "Sąskaitos
perkėlimas"; verify with the localization glossary which term matches the
intended semantic context (breadcrumb vs label) and then standardize both keys
to the chosen term for consistency, updating the value for the "Account
Transfers" JSON key and/or the "labels.catalogs" value accordingly so both use
the approved Lithuanian phrase.
🧹 Nitpick comments (3)
src/assets/translations/es-MX.json (1)
309-310: Verify translation consistency with existing entries.The JSON syntax is correct. However, the translation "Transferencias entre cuentas" differs from the existing pattern used elsewhere in this file:
- Line 2794:
"Account Transfer": "Transferencia de cuenta"(singular)- Line 623:
"Account transfer": "Transferencia de cuenta"(singular)- Lines 557-558:
"Account_transfer": "Transferencia de Cuenta"(singular)The new translation uses the plural form "Transferencias" and adds "entre cuentas" (between accounts), while existing entries use the singular "Transferencia de Cuenta/cuenta" pattern.
Consider whether "Transferencias de Cuentas" would better align with the existing translation pattern, or verify that the current choice ("Transferencias entre cuentas") better represents the feature's purpose in the UI.
src/app/account-transfers/account-transfers-routing.module.ts (1)
68-84: LGTM - Translation key correctly applied for breadcrumb internationalization.The breadcrumb now uses the i18n translation key
labels.breadcrumbs.Account Transferswhich aligns with the translation entries added to the locale files. TherouteParamBreadcrumb: falsesetting is appropriate for a static label.Consider: Other routes in this file (e.g., lines 37-41, 49, 57-61) still use hardcoded strings for breadcrumbs. For full i18n consistency, you may want to translate those breadcrumbs in a follow-up task.
src/assets/translations/cs-CS.json (1)
309-310: Consider translation consistency for "Account Transfers"The new breadcrumb translation "Account Transfers": "Převody mezi účty" (Transfers between accounts) is more verbose than the existing pattern used elsewhere in the file. For reference:
- Line 876 & 2791: "Account Transfer": "Převod účtu"
A simpler plural form like "Převody účtů" might provide better consistency with existing translations, unless the more descriptive breadcrumb label is intentional for improved navigation clarity.
The JSON syntax is correct, and the trailing comma addition on line 309 properly accommodates the new field.
|
Lgtm |
|
@IOhacker Thank You for the review |
Changes Made :-
-Internationalized the "Account Transfers" breadcrumb by replacing the hardcoded label with an i18n translation key in the routing module.
-Added the "Account Transfers" key to all locale translation files under the breadcrumbs section, using proper translations or English fallback where needed.
WEB-594
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.