-
Notifications
You must be signed in to change notification settings - Fork 849
WEB-572:fix(i18n) localize loan-product import dialog and add transla… #2987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -438,10 +438,12 @@ | |
| "Group Saving Application": "Gruppenspeicheranwendung", | ||
| "Hide Incentives": "Anreize ausblenden", | ||
| "Home Screen Tour": "Startbildschirm-Tour", | ||
| "Import": "Importieren", | ||
| "Import Center": "Importcenter", | ||
| "Import Client": "Client importieren", | ||
| "Import Employees": "Mitarbeiter importieren", | ||
| "Import Group": "Gruppe importieren", | ||
| "Import Loan Product": "Kreditprodukt importieren", | ||
| "Import Offices": "Importbüros", | ||
| "Initiate Dividend": "Dividende einleiten", | ||
| "Link Job Step": "Jobschritt verknüpfen", | ||
|
|
@@ -3269,6 +3271,7 @@ | |
| "Search by user": "Suche nach Benutzern", | ||
| "Section Buttons": "Dieser Abschnitt enthält den Benutzernamen, das Benutzerfoto, die Benutzereinstellungen und die Schaltfläche zum Abmelden.", | ||
| "select": "wählen", | ||
| "Select a JSON file containing the loan product definition": "Wählen Sie eine JSON-Datei mit der Kreditproduktdefinition aus", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Translation key path mismatch will cause lookup failure. The template uses Move this key into a 🐛 Proposed fix: Create labels.text sectionThe key should be nested under
"labels": {
+ "text": {
+ "Select a JSON file containing the loan product definition": "Wählen Sie eine JSON-Datei mit der Kreditproduktdefinition aus"
+ },
"accounting": {And remove the key from line 3274. 🤖 Prompt for AI Agents |
||
| "SelectDate": "Datum auswählen", | ||
| "SelectOrTypeClientName": "Kundenname auswählen oder eingeben", | ||
| "Selection you can create new drop-downs and edit": "Von dieser Auswahl aus können Sie neue Dropdowns erstellen und deren Werte bearbeiten sowie die Werte für vom System generierte Codes und Dropdowns bearbeiten.", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -439,10 +439,12 @@ | |
| "Group Saving Application": "Group Saving Application", | ||
| "Hide Incentives": "Hide Incentives", | ||
| "Home Screen Tour": "Home Screen Tour", | ||
| "Import": "Import", | ||
| "Import Center": "Import Center", | ||
| "Import Client": "Import Client", | ||
| "Import Employees": "Import Employees", | ||
| "Import Group": "Import Group", | ||
| "Import Loan Product": "Import Loan Product", | ||
| "Import Offices": "Import Offices", | ||
| "Initiate Dividend": "Initiate Dividend", | ||
| "Link Job Step": "Link Job Step", | ||
|
|
@@ -3372,6 +3374,7 @@ | |
| "Search bar to filter fixed deposit products.": "Search bar to filter fixed deposit products.", | ||
| "Search by user": "Search by user", | ||
| "Section Buttons": "This section contains user name, user photograph, user settings and sign out button.", | ||
| "Select a JSON file containing the loan product definition": "Select a JSON file containing the loan product definition", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
# Expect: template(s) reference the exact full key path(s) that exist in JSON.
rg -n --hidden --glob '!**/node_modules/**' --fixed-string \
"labels.buttons.Import" \
"labels.buttons.Import Loan Product" \
"labels.text.Select a JSON file containing the loan product definition" \
"Select a JSON file containing the loan product definition"Repository: openMF/web-app Length of output: 505 🏁 Script executed: #!/bin/bash
set -euo pipefail
# Expect: template(s) reference the exact full key path(s) that exist in JSON.
rg -n --hidden --glob '!**/node_modules/**' --fixed-strings \
"labels.buttons.Import" \
"labels.buttons.Import Loan Product" \
"labels.text.Select a JSON file containing the loan product definition" \
"Select a JSON file containing the loan product definition"Repository: openMF/web-app Length of output: 340 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "=== Searching for labels.text.Select reference ==="
rg -n --hidden "labels\.text\.Select a JSON file containing the loan product definition" || echo "Not found"
echo ""
echo "=== Searching for labels.buttons.Import references ==="
rg -n --hidden "labels\.buttons\.Import" || echo "Not found"
echo ""
echo "=== Searching for the unqualified string ==="
rg -n --hidden "Select a JSON file containing the loan product definition" || echo "Not found"Repository: openMF/web-app Length of output: 3787 🏁 Script executed: #!/bin/bash
# Check the structure around line 3377 in en-US.json
sed -n '3370,3385p' src/assets/translations/en-US.jsonRepository: openMF/web-app Length of output: 1216 🏁 Script executed: #!/bin/bash
# Get broader context to see the full structure
sed -n '3350,3380p' src/assets/translations/en-US.jsonRepository: openMF/web-app Length of output: 2417 🏁 Script executed: #!/bin/bash
# Find which object these keys belong to by looking earlier in the file
head -n 3380 src/assets/translations/en-US.json | tail -n 100 | head -n 40Repository: openMF/web-app Length of output: 2348 🏁 Script executed: #!/bin/bash
# Find the parent structure by searching for "labels" key and understanding the nesting
rg -n '"labels"' src/assets/translations/en-US.json | head -5Repository: openMF/web-app Length of output: 75 🏁 Script executed: #!/bin/bash
# Check the structure inside labels object
sed -n '287,320p' src/assets/translations/en-US.jsonRepository: openMF/web-app Length of output: 1228 🏁 Script executed: #!/bin/bash
# Search for which sub-object contains the "Select a JSON file" key
# by looking for nearby object boundaries
sed -n '3300,3380p' src/assets/translations/en-US.json | grep -B50 "Select a JSON file"Repository: openMF/web-app Length of output: 4289 🏁 Script executed: #!/bin/bash
# Search for where "text" object starts/ends in labels
rg -n '"text"' src/assets/translations/en-US.jsonRepository: openMF/web-app Length of output: 76 🏁 Script executed: #!/bin/bash
# Check the structure: where does "text" start and what comes after it?
# Also check what object the key at line 3377 belongs to
sed -n '2790,2810p' src/assets/translations/en-US.json
echo "---"
sed -n '3375,3385p' src/assets/translations/en-US.jsonRepository: openMF/web-app Length of output: 2642 Fix the template to use the correct translation key path. The template in 🤖 Prompt for AI Agents |
||
| "select": "select", | ||
| "SelectDate": "Select date", | ||
| "SelectOrTypeClientName": "Select or type client name", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -438,10 +438,12 @@ | |
| "Group Saving Application": "Demande d'épargne de groupe", | ||
| "Hide Incentives": "Masquer les incitations", | ||
| "Home Screen Tour": "Visite guidée de l'écran d'accueil", | ||
| "Import": "Importer", | ||
| "Import Center": "Centre d'importation", | ||
| "Import Client": "Importer un client", | ||
| "Import Employees": "Importer des employés", | ||
| "Import Group": "Groupe d'importation", | ||
| "Import Loan Product": "Importer un produit de prêt", | ||
| "Import Offices": "Bureaux d'importation", | ||
| "Initiate Dividend": "Initier le dividende", | ||
| "Link Job Step": "Lier l'étape de travail", | ||
|
|
@@ -3268,6 +3270,7 @@ | |
| "Search by user": "Recherche par l'utilisateur", | ||
| "Section Buttons": "Cette section contient le nom d'utilisateur, la photo de l'utilisateur, les paramètres utilisateur et le bouton de déconnexion.", | ||
| "select": "sélectionner", | ||
| "Select a JSON file containing the loan product definition": "Sélectionnez un fichier JSON contenant la définition du produit de prêt", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix likely translation key path mismatch ( 🤖 Prompt for AI Agents |
||
| "SelectDate": "Sélectionner la date", | ||
| "SelectOrTypeClientName": "Sélectionner ou saisir le nom du client", | ||
| "Selection you can create new drop-downs and edit": "À partir de cette sélection, vous pouvez créer de nouvelles listes déroulantes et modifier leurs valeurs, ainsi que modifier les valeurs des codes et des listes déroulantes générés par le système.", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the description translation key to match JSON structure.
Given the fr-FR entry is under
labels.text, Line 12 likely needslabels.text.…(otherwise you’ll see the raw key).Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents