WEB-478-fix/i18n/savings-account-details-missing

[shubhamkumar9199]

Description

This PR Added missing translation key "Savings Account Details" to the translation files so the page title displays properly instead of showing the raw translation key.

#{Issue Number}
WEB-478

Screenshots, if any

before:

after:

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• If you have multiple commits please combine them into one commit by squashing them.

• Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

• Documentation
  • Added the "Savings Account Details" UI label translations in 13 languages: Czech, German, English, Spanish (CL & MX), French, Italian, Korean, Lithuanian, Latvian, Nepali, Portuguese, and Swahili.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'pre_merge_checks'

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

Added the translation key "Savings Account Details" with localized strings to 13 translation files. No code, logic, or control-flow changes were made.

Changes

Cohort / File(s)

Summary

Translation files - Savings Account Details src/assets/translations/cs-CS.json, src/assets/translations/de-DE.json, src/assets/translations/en-US.json, src/assets/translations/es-CL.json, src/assets/translations/es-MX.json, src/assets/translations/fr-FR.json, src/assets/translations/it-IT.json, src/assets/translations/ko-KO.json, src/assets/translations/lt-LT.json, src/assets/translations/lv-LV.json, src/assets/translations/ne-NE.json, src/assets/translations/pt-PT.json, src/assets/translations/sw-SW.json

Added new translation entry "Savings Account Details" with language-specific values (e.g., Czech: "Podrobnosti spořicího účtu", German: "Sparkonto-Details", Spanish: "Detalles de la cuenta de ahorros", etc.). No existing keys removed or modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

• Verify presence of the new key in all listed files.
• Confirm localized strings are correct and free of encoding issues.
• Check placement consistency (near "All Savings") and JSON validity.

Suggested reviewers

• IOhacker
• AlejandroED21

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding missing translation keys for savings account details across i18n files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a23034 and 2498eb1.

📒 Files selected for processing (13)

• src/assets/translations/cs-CS.json (1 hunks)
• src/assets/translations/de-DE.json (1 hunks)
• src/assets/translations/en-US.json (1 hunks)
• src/assets/translations/es-CL.json (1 hunks)
• src/assets/translations/es-MX.json (1 hunks)
• src/assets/translations/fr-FR.json (1 hunks)
• src/assets/translations/it-IT.json (1 hunks)
• src/assets/translations/ko-KO.json (1 hunks)
• src/assets/translations/lt-LT.json (1 hunks)
• src/assets/translations/lv-LV.json (1 hunks)
• src/assets/translations/ne-NE.json (1 hunks)
• src/assets/translations/pt-PT.json (1 hunks)
• src/assets/translations/sw-SW.json (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• src/assets/translations/sw-SW.json

🚧 Files skipped from review as they are similar to previous changes (7)

• src/assets/translations/fr-FR.json
• src/assets/translations/ko-KO.json
• src/assets/translations/en-US.json
• src/assets/translations/de-DE.json
• src/assets/translations/cs-CS.json
• src/assets/translations/it-IT.json
• src/assets/translations/ne-NE.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Run Lint, Build and Deploy

🔇 Additional comments (5)

src/assets/translations/lv-LV.json (1)

2747-2747: ✓ Translation addition is correct and well-placed.

The "Savings Account Details" translation entry is properly formatted and positioned within the logical grouping of savings-related translations. The Latvian translation "Krājkonta informācija" is grammatically accurate and maintains consistency with existing terminology patterns in the file (e.g., "Savings Account": "Krājkonts", "Savings Products": "Uzkrājumu produkti").

src/assets/translations/pt-PT.json (1)

2747-2747: ✓ Straightforward translation addition—looks good.

The new translation entry "Savings Account Details": "Detalhes da Conta Poupança" is correctly placed among savings-related translations and uses accurate Portuguese phrasing. The JSON formatting is consistent with surrounding entries.

Since this change is part of a broader 13-file localization update, ensure consistency across all locale files at merge time—verify that the translation key appears in each of the intended translation files and uses appropriate translations for each language.

src/assets/translations/es-CL.json (1)

2747-2747: Translation key added correctly with accurate Spanish localization.

The new "Savings Account Details" entry is properly positioned after "All Savings" with an accurate Spanish translation. The JSON syntax is correct and consistent with the file's structure.

src/assets/translations/lt-LT.json (1)

2747-2747: ✓ Translation key addition looks good.

The new "Savings Account Details" translation entry is properly formatted, correctly placed within the "text" section, and follows the established pattern of adjacent entries. JSON syntax is valid with appropriate comma placement and indentation.

Note: This review covers only the lt-LT.json file shown. Per the PR description, the same key has been added to 12 other translation files. Please ensure consistent formatting and translation quality across all locales.

src/assets/translations/es-MX.json (1)

2749-2749: Translation entry added correctly with valid Spanish localization.

The new "Savings Account Details" translation entry with value "Detalles de la cuenta de ahorros" is syntactically valid and appropriately placed within the "text" section alongside related entries. The Spanish translation accurately represents the English key.

Note: The AI summary indicates the path should be "errors.Savings Account Details," but the actual code placement is in the "text" section (line 2716 onwards). Verify this is the intended location for page title translations across the codebase.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gkbishnoi07]

i think you added two times can you please confirm?
the 2nd one is in line no 2757

[shubhamkumar9199]

@gkbishnoi07 Apologies for the earlier mistake. The issue has been resolved and the file is now corrected

[IOhacker]

LGTM

[alberto-art3ch]

LGTM