Skip to content

WEB-436: Fix Spanish Translation for Login Page and Family Members tab#2820

Merged
steinwinde merged 1 commit intoopenMF:devfrom
FintecheandoMX:dev
Nov 26, 2025
Merged

WEB-436: Fix Spanish Translation for Login Page and Family Members tab#2820
steinwinde merged 1 commit intoopenMF:devfrom
FintecheandoMX:dev

Conversation

@IOhacker
Copy link
Contributor

@IOhacker IOhacker commented Nov 26, 2025

Description

Fix Spanish Translation for Login Page and Family Members tab

Related issues and discussion

WEB-436

Screenshots, if any

image

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

  • Documentation
    • Updated Spanish-language translations across regional variants for improved clarity and more natural phrasing in UI text.
    • Refined wording for better engagement and localization consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 26, 2025

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

Updated Spanish translation strings across Chilean and Mexican Spanish locale files. Changes include terminology updates for family references, grammatical corrections, and refined phrasing for engagement and poverty-related descriptions.

Changes

Cohort / File(s) Summary
Spanish Translation Updates
src/assets/translations/es-CL.json, src/assets/translations/es-MX.json
Updated terminology: "Family Member"/"Family Members" → "Referencia personal"/"Referencias personales"; grammatical fixes ("A" → "Una", "está diseñado por el" → "está diseñado por la"); refined "Get involved" messaging to "¡Te invitamos a involucrarte"; updated "elimination of poverty" description to "las personas de escasos recursos y no bancarizados alrededor del mundo"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Translation-only updates with no logic or control-flow changes
  • Homogeneous changes across two similar locale files (repetitive patterns)
  • Purely cosmetic/content modifications to user-facing strings

Suggested reviewers

  • AlejandroED21
  • gkbishnoi07

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly matches the changeset, clearly identifying the specific translation fixes for Spanish on the Login Page and Family Members tab across multiple translation files (es-CL.json and es-MX.json).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 884ef27 and 4397ae2.

📒 Files selected for processing (2)
  • src/assets/translations/es-CL.json (4 hunks)
  • src/assets/translations/es-MX.json (4 hunks)
🔇 Additional comments (10)
src/assets/translations/es-MX.json (5)

3332-3332: Gender agreement correction verified.

The change from "está diseñado por el" to "está diseñado por la" correctly applies gender agreement in Spanish when the implied subject (the organization/system) is feminine. This grammatical improvement is appropriate.


3012-3012: Improved engagement tone for user-facing copy.

The update from "Involucrarse" to "¡Te invitamos a involucrarte" transforms the message from imperative to a more inviting, inclusive invitation. This aligns well with login page UX patterns and creates a warmer user experience. The exclamation marks and second-person informal pronoun ("te") are appropriate for Spanish user interfaces.


3330-3330: Verify extended "elimination of poverty" description.

The translation update for "elimination of poverty" significantly expands the text to describe "las personas de escasos recursos y no bancarizados alrededor del mundo." Confirm that this extended description:

  • Does not exceed space constraints in the UI (especially on login page)
  • Accurately reflects the intended meaning from any source English text
  • Maintains consistency with the same text in es-CL.json (as indicated in the AI summary)

2711-2711: Grammatical article update for Spanish correctness.

The change from "A" to "Una" (line 2711, heading section) applies the correct indefinite article in Spanish. This improves grammatical accuracy in the heading context.


1-1: Verify parallel changes in es-CL.json and completeness.

The AI summary indicates that similar translation updates were made to src/assets/translations/es-CL.json (Chilean Spanish). Ensure:

  1. Corresponding keys in es-CL.json match the changes made here (especially for "Family Members" to maintain consistency between regional variants where applicable)
  2. All referenced translation keys in the PR description have been updated in both locale files
  3. No translation keys were missed or partially updated

Consider running a diff comparison between the old and new versions of both files to catch any unintended changes or omissions.

Also applies to: 2-3352

src/assets/translations/es-CL.json (5)

2709-2709: Verify single-character text key "A" is correctly contextualized.

The change from "A" to "Una" appears to be a grammatical correction (article/gender agreement), but without context of where this key is displayed, the full impact cannot be assessed. Ensure:

  • The text is displayed in a context where "Una" (feminine singular) is appropriate
  • No UI layout issues or display truncation occurs
  • The gender agreement matches the noun it modifies
  • This change is visible on the Login Page or Family Members tab per WEB-436 scope

3010-3010: Approved: Engaging call-to-action translation for "Get involved".

The updated translation from "Involucrarse" to "¡Te invitamos a involucrarte!" effectively shifts from a neutral infinitive to an engaging, personalized call-to-action. The use of second person ("te") and exclamation marks enhances user engagement, which aligns well with the PR's stated objective of "refined phrasing for engagement." This is a quality localization improvement.


3328-3328: Verify expanded "elimination of poverty" text fits UI display context and PR scope.

The translation for "elimination of poverty" has been significantly expanded from what was likely a brief phrase into a full descriptive paragraph with mission statement, target audience details, and an engaging rhetorical question. While the content is well-written and contextually appropriate, this represents more than a translation correction—it's content expansion.

Verify:

  • The text displays properly in its intended UI context without layout overflow
  • This expansion is intentional per WEB-436 and not accidental
  • Space constraints and responsive design accommodate this longer text
  • The addition aligns with the scope of "fixing translations" vs. adding new descriptive content

3330-3330: Approved: Grammatical gender agreement correction for "is designed by the".

The correction from "está diseñado por el" (masculine) to "está diseñado por la" (feminine) properly adjusts the article to match the gender of the noun it modifies. This is a straightforward grammatical fix that improves Spanish language correctness. No concerns identified.


931-932: The terminology shift from "Miembro de la familia" to "Referencia personal" is intentional and consistent across locales, but represents a significant semantic change that warrants confirmation.

The WEB-436 PR intentionally updates both es-CL.json and es-MX.json to use "Referencia personal" / "Referencias personales" terminology instead of "Miembro de la familia" / "Miembros de la familia". This change is consistent between both locales and accompanied by other translation refinements for Login Page and Family Members contexts.

However, this constitutes a semantic shift beyond simple translation correction—changing the conceptual meaning from "family member" to "personal reference." While the terminology is grammatically correct Spanish and appears deliberate (not an error), it warrants verification that:

  1. UI labels actually reflect this terminology change – Confirm that the Family Members tab UI now displays "Referencia personal" and that this aligns with the intended user experience.
  2. The terminology choice is appropriate for the domain – If family members are managed as reference contacts in the system, "Referencia personal" is semantically correct; otherwise, this may be a misaligned term choice.

If the Family Members tab is indeed redesigned to use reference terminology, the change is appropriate. If not, revert to the literal "Miembro de la familia" terminology.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator

@steinwinde steinwinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steinwinde steinwinde merged commit 5effdb9 into openMF:dev Nov 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants