WEB-256 replace custom api of groups.service.ts #2586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkbishnoi07
requested changes
Aug 16, 2025
|
@JaySoni1 are you still working on this PRs? |
i'm working on this pr |
|
@gkbishnoi07 I have updated this pr please review. |
getting some errors while creating group
|
gkbishnoi07
reviewed
Aug 28, 2025
| @@ -30,17 +36,21 @@ export class GroupActionsResolver { | |||
| case 'Attendance': | |||
| case 'Manage Members': | |||
| case 'Transfer Clients': | |||
| return this.groupsService.getGroupData(groupId); | |||
| return this.groupsService.delete11({ groupId: Number(groupId) }); | |||
There was a problem hiding this comment.
delete11 is wrong the correct operationId is retrieveOne15
gkbishnoi07
reviewed
Aug 28, 2025
| const groupId = route.paramMap.get('groupId'); | ||
| return this.groupsService.getGroupData(groupId, 'true'); | ||
| const groupId = Number(route.paramMap.get('groupId')); | ||
| return this.groupsService.delete11({ groupId: groupId }); |
There was a problem hiding this comment.
there should be get operationID not delete
gkbishnoi07
reviewed
Aug 28, 2025
| @@ -25,6 +25,11 @@ export class GroupSummaryResolver { | |||
| */ | |||
| resolve(route: ActivatedRouteSnapshot): Observable<any> { | |||
| const groupId = route.parent.paramMap.get('groupId'); | |||
| return this.groupsService.getGroupSummary(groupId); | |||
| // Use runReport1 with reportName and query params | |||
| return this.selfRunReportService.runReport1({ | |||
There was a problem hiding this comment.
for now, don't use runreport endpoint add this endpoint in customApis.ts file
getGroupSummary(groupId: string): Observable<any> {
const httpParams = new HttpParams().set('R_groupId', groupId).set('genericResultSet', 'false');
return this.http.get(`/runreports/GroupSummaryCounts`, { params: httpParams });
}
|
Do a squash and commit |
@IOhacker ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced custom methods in *.ts files that were previously using Groupsservice with their corresponding auto-generated methods from the OpenAPI-based @fineract/client package.
Related issues and discussion
WEB-256