Repository navigation
Write the README - #3
Merged
Merged
Conversation
The repo was seeded with the scaffold placeholder still in place, so the only thing it said about itself was its own name. It now describes the service: the token endpoints and their lifetimes, the user/role/ permission and read-only workflow APIs under /api/v1, how other components verify a token with the published public key rather than calling here, and the multi-tenant rule that every call except /oauth/token_key must name a tenant. Also the parts a newcomer gets stuck on: the service listens on 5000 and needs a MySQL holding the tenant list, the committed application.properties points at the in-cluster host name, and jwt.pem is a development key pair that a real deployment has to replace. Every claim was read off the code rather than assumed: the /api/v1 class level mapping on the four API classes, the HTTP methods on the three /oauth paths, the token lifetimes in application.properties, the tenant filter running ahead of security via securityFilterOrder - 4, and the Flyway migration loop over every tenant at startup.
tdaly61
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo was seeded with the scaffold placeholder still in place, so the only thing the README said about
paymenthub-ee-authwas its own name. Every other migrated component has a written one; this closes the gap.It now covers what the service is: it issues the RSA-signed JWTs the rest of Payment Hub EE checks, and owns the users, roles and permissions behind them. The token endpoints and their lifetimes (10 minutes for an access token, 12 hours for a refresh token), the user/role/permission APIs and the read-only workflow views under
/api/v1, and the point that other components verify a token against the public key published at/oauth/token_keyrather than calling this service per request — so it is not on the hot path of a payment.It also states the multi-tenant rule, which is the thing that makes a first call fail in a way that is hard to guess: every request except
/oauth/token_keyhas to name a tenant, in thePlatform-TenantIdheader or atenantIdentifierparameter, and a request without one is rejected before authentication runs, because the tenant decides which database the user is looked up in.Plus the practical parts: port 5000, the MySQL instance holding the tenant list, the fact that the committed
application.propertiespoints at the in-cluster host nameoperations-mysqland which properties to override for a local run, and thatjwt.pemis a development key pair a real deployment must replace, since anything holding the private key can mint a token every other component accepts.Every claim was read off the code, not assumed: the class-level
@RequestMapping("/api/v1")onUsersApi,RolesApi,PermissionsApiandOperationsDetailedApi; the HTTP methods on the three/oauthpaths (POST,GET,POST); the two validity values inapplication.properties; the tenant filter registering atsecurityFilterOrder - 4so it runs ahead of Spring Security; and the Flyway loop overrepository.findAll()at startup. EclipseLink rather than Hibernate is from thehibernate-coreexclusion inbuild.gradle, and no actuator is claimed because the dependency is not there.Docs only — no code, build or config changes.